From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 63749FFA for ; Mon, 25 Sep 2017 11:04:54 +0200 (CEST) Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id D1AD860050; Mon, 25 Sep 2017 09:04:53 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx3-us1.ppe-hosted.com (filterqueue.mdlocal [10.7.20.246]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 54441100067; Mon, 25 Sep 2017 09:04:53 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 136A52006C; Mon, 25 Sep 2017 09:04:53 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 25 Sep 2017 10:04:48 +0100 To: Ferruh Yigit , CC: Chas Williams References: <1506322206-30233-1-git-send-email-arybchenko@solarflare.com> <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com> From: Andrew Rybchenko Message-ID: <080aa50a-14bc-c298-9a49-d83e026c53ab@solarflare.com> Date: Mon, 25 Sep 2017 12:04:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23350.003 X-TM-AS-Result: No--11.661900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1506330293-Tzw9Hdx8wkCs Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 09:04:54 -0000 On 09/25/2017 11:42 AM, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: >> Failure happens on build using: >> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > Yes, that case is missed. What do you think about following one: > > @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, > unsigned int blockcnt, > unsigned int framesize, > unsigned int framecnt, > - unsigned int qdisc_bypass, > + unsigned int qdisc_bypass __rte_unused, > struct pmd_internals **internals, > struct rte_eth_dev **eth_dev, > struct rte_kvargs *kvlist) It is OK for me as well, but I've not chosen it since it could be treated as always unused. >> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") >> >> Signed-off-by: Andrew Rybchenko >> --- >> May be the right solution in fact remove PACKET_QDISC_BYPASS conditional >> completely. If below solution is accepted, feel free to squash it into >> the original patch. > It is a little to late for this, I already sent a pull-request with this > patch. So fix will need to be a separate patch. Sad, if it means that the build will be broken in main DPDK repo as well. Not critical, but a bit inconvenient. > <...>