From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5C96B1B3E8 for ; Wed, 26 Sep 2018 18:01:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 09:00:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="265922293" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.84]) ([10.252.17.84]) by fmsmga005.fm.intel.com with ESMTP; 26 Sep 2018 09:00:54 -0700 To: "Kovacevic, Marko" , "dev@dpdk.org" Cc: "Mcnamara, John" , "laszlo.madarassy@ericsson.com" , "laszlo.vadkerti@ericsson.com" , "andras.kovacs@ericsson.com" , "winnie.tian@ericsson.com" , "daniel.andrasi@ericsson.com" , "janos.kobor@ericsson.com" , "geza.koblo@ericsson.com" , "srinath.mannam@broadcom.com" , "scott.branden@broadcom.com" , "ajit.khaparde@broadcom.com" , "Wiles, Keith" , "Richardson, Bruce" , "thomas@monjalon.net" , "shreyansh.jain@nxp.com" , "shahafs@mellanox.com" , "arybchenko@solarflare.com" References: <6DC05C7C5F25994B81B3F2F214251F66020313C2@IRSMSX104.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: <081911b3-4773-747d-52b1-ccce62be6971@intel.com> Date: Wed, 26 Sep 2018 17:00:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66020313C2@IRSMSX104.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 21/21] doc: add external memory feature to programmer's guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 16:01:13 -0000 On 26-Sep-18 4:19 PM, Kovacevic, Marko wrote: >> Add a short chapter on usage of external memory in DPDK to the >> Programmer's Guide. >> >> Signed-off-by: Anatoly Burakov >> --- >> .../prog_guide/env_abstraction_layer.rst | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) > >> +The expected workflow is as follows: >> + >> +* Get a pointer to memory area >> +* Create a named heap >> +* Add memory area(s) to the heap >> + * If IOVA table is not specified, IOVA addresses will be assumed to be >> + unavailable, and DMA mappings will not be performed >> + * Other processes must attach to the memory area before they can use >> +it >> +* Get socket ID used for the heap >> +* Use normal DPDK allocation procedures, using supplied socket ID >> +* If memory area is no longer needed, it can be removed from the heap >> + * Other processes must detach from this memory area before it can be >> +removed >> +* If heap is no longer needed, remove it >> + * Socket ID will become invalid and will not be reused > > > Hi Anatoly, > > Im getting an error when doing > > make-doc-guides-html > > /dpdk/doc/guides/prog_guide/env_abstraction_layer.rst:241: WARNING: Unexpected indentation. > /dpdk/doc/guides/prog_guide/env_abstraction_layer.rst:242: WARNING: Block quote ends without a blank line; unexpected unindent. > > This is due to the indentation of your inner bullet points instead of two spaces put 4 > For all four that you have. > > Thanks, > Marko K > Hi Marko, Those are supposed to be sub-bullet points, i.e. 2nd level. Does it have to be six? -- Thanks, Anatoly