From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A4D3A2EDB for ; Fri, 6 Sep 2019 08:50:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D53791F124; Fri, 6 Sep 2019 08:50:07 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 185D21F122 for ; Fri, 6 Sep 2019 08:50:05 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8F8DAFFBD99609415947; Fri, 6 Sep 2019 14:50:03 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Fri, 6 Sep 2019 14:49:53 +0800 To: Ferruh Yigit , References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-5-git-send-email-xavier.huwei@huawei.com> <30af42d3-c582-fac0-c13f-8c52f063bd14@intel.com> CC: , , , From: "Wei Hu (Xavier)" Message-ID: <082a2b54-0641-42ea-d327-0614ebbef8fc@huawei.com> Date: Fri, 6 Sep 2019 14:49:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <30af42d3-c582-fac0-c13f-8c52f063bd14@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh Yigit On 2019/8/30 23:02, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch adds support for cmd of hns3 PMD driver, driver can interact >> with firmware through command to complete hardware configuration. >> >> Signed-off-by: Hao Chen >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Huisong Li > <...> > >> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h >> index bfb54f2..84fcf34 100644 >> --- a/drivers/net/hns3/hns3_ethdev.h >> +++ b/drivers/net/hns3/hns3_ethdev.h >> @@ -39,7 +39,6 @@ >> >> #define HNS3_4_TCS 4 >> #define HNS3_8_TCS 8 >> -#define HNS3_MAX_TC_NUM 8 > This definition is used by 'hns3_ethdev.h' but moved to 'hns3_cmd.h', and > 'hns3_ethdev.h' doesn't include 'hns3_cmd.h', which will force whatever .c file > include 'hns3_ethdev.h' to include 'hns3_cmd.h' before it and these kind of .h > order dependencies are easy to break. > Would it work if 'hns3_ethdev.h' includes 'hns3_cmd.h' > We will update it and send patch V2. Thanks for your suggestion. Regards Xavier >