From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0055.outbound.protection.outlook.com [104.47.38.55]) by dpdk.org (Postfix) with ESMTP id 5E525AAF5 for ; Mon, 2 Apr 2018 18:13:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cYH3sl4stER1kycNHG4xcCljrGuxXny94+Tt1mViW6k=; b=XTiIj7QJ7vfBRa7NScSafcOvjyIzpcb9AKQNJSiSNqC59EkM2WaV4Q7jxgbtMEF64kTwXbESirFA3PH5NNi3jQ9DU8uiKjwYKbF+M2VyRLXjs0riUxjHY5Qv0EbLbCpujUhYtxXBmzYANYQyWn8IM0bPjn2/QGIF0AFZr8U1yT4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.0.106] (103.76.56.167) by SN1PR0701MB1903.namprd07.prod.outlook.com (2a01:111:e400:517b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Mon, 2 Apr 2018 16:13:40 +0000 To: David Marchand , Ferruh Yigit Cc: dev@dpdk.org, Shreyansh Jain , Allain Legacy , Tomasz Duszynski References: <20180329175206.127943-1-ferruh.yigit@intel.com> <20180330151704.183495-1-ferruh.yigit@intel.com> From: santosh Message-ID: <08358c50-1076-21c0-cf79-25d7a25d6255@caviumnetworks.com> Date: Mon, 2 Apr 2018 21:43:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: HK2PR04CA0077.apcprd04.prod.outlook.com (2603:1096:202:15::21) To SN1PR0701MB1903.namprd07.prod.outlook.com (2a01:111:e400:517b::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 294b5b86-1663-479c-1aaa-08d598b4b456 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN1PR0701MB1903; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 3:DSvHwatnE1cNZ9mwYSrsNzUGuQB7FFYJ9JveHwHGkTLLhMqorRxpiV4Zbamp94QV2S5Uf7afmLjLA3aMGrbFVhXLRz1AJjxwmxNrO/BUu2Pn/Bvy1vB/joUm/zN8WlYgiiMZ+y0+2UkJ8NkyVLA5s8ANzI/re5GCUmSnZZgp9O9ur5GcITgf+SQSaqFQr4yXWHEHyfuCNmPND8BTVyi7Uz8YlIK5/e9/7fnIQKUpWO4o+xXsOfjVPfcNzXycjRIv; 25:hu8ObNxPK19FkuXypWZFuq08azMhVot7R0bKHMWNgG2l6hJ8JLMoUnd/ibVkP5OH6Pjv6fsgwL/Zbl2qBtWimLOh5nRcIBUhlJRXSLJGm/M+Lc9eauXrzvpSpe1P3FBc/qjmRe2bsbET7w3Vo6QW1AejwGGB4Dm9I0BMQdlylHydFUhWQRKtFS1TCxodMbbYbxJhGlkzqYxJKaIjqPoXGJ7JU8m8gXokpdMzganGb5/ccjYGQwlN2ycPGD8yhg9O5GVgexhV6zVOK6obFNQbVGfVSPOvxLrVle3jpyVuMa25x1atv+VsUWUcbmUJuuOZHKsvTK6mjVdRuXN+/JPYaA==; 31:4Z2zK/Qyj8G/RzMT78EFTcFldJ789MaLQ1c/40h4F37foa4pAT2zL59D0RYd5aNjgQVNGoXPD2H5UFt+/kqw8Hpv8auRjsXpNlY4gkkQQulRSXuFPfeRbzwVjg782t8lJijyoxLNghcpBq62uQVy/8oU+8rmxObyvCDTPCNtB6TJAMX/1f53SXeACNOzJkTyvwdq8Yf6Zn623ZK6Yz0D+cZMUFf7lV3/uc2BFBKo/EI= X-MS-TrafficTypeDiagnostic: SN1PR0701MB1903: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 20:hkO431PO/aW6vol37gZbhTiWhPWauiUjUS7ELdE0PQPyeJv1A6yTM7yPtVZGgB5LbMqJeGGK4yHb6foOEChuAdwoG8B4fRhiSvN1eZ/4/bDK0crlyghwAI3rFWoV1+pJHTaLa6NK4F2rIcuRKGmnRkqPVyzpEFtVCrbs739Zyvui/AGjdLbzJQTS+IEAEx2lLYJrJNBdFy2xU0s67IXfU0iEj/N8sPYqhwgz3gmhkzYsLu9Q84VcxhCpUam2Terg0xs+qgys1yVEXvpbqsQ6a1YNhYnDBFnTiAFEIppxQu/ezrrfBX53h/62JpWmpf4q6NKhmEUjTk2MexuvoCpQ3ynSAnJ7KO47PtvicFf7TKMem0IfHjDqNso4J9fDJe1hrNvdd0EQqDeSvsZWX+PGYoXn02XeiSYoiNyNjHYIg7P0ust2tX1oT4SrWoAlHMPXIhRmF3gYnZCDhUP1STH4p7rrk818JRmA9gWK2wo2O+aZL80WHQ6W2XLwsB5AziKce9x5xd49D6k6D00rbOG+ZSWjk1vn7OtY6X1NipegWqMlo0klurnQky4GD5VSzvlc67dQVpADhSdrBTgxaynOgQzKOMsk8rkcPmQo1q7TvwU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3002001)(3231221)(944501327)(52105095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:SN1PR0701MB1903; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB1903; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 4:bRIr6Q8ozAoc1hqX3jrdxUGQSRYYtooYMZXB/w2ekztGcWUkvi4cOau4q/hSzd4BJfm2EJvVRQleZpAhOFatIhNcFIfhnYo5Ht1qxKr1Y/pj/BHuvKT7/59ZQugSU/X/GIE3nSeGOwHSLSLpauxwtIO53AOxbjqu9YnZOZuu6nNZL9Yi804umaypE/00rdWqNXAzsiyRmfgfsg6F2IGD/8Y0W2M250SNqT6ngp8GCXsHkxm6tShAtq68I2KwbmPhuvy1ICLJgdbDjvZxyAr55Mt6iIHFIuVdJTxwaC9C6E6KHc4P/tYbX8XW+kOJ8WxPLV7cVRj3GruHpbx9vSX185DjHnqSKtoA9TBdTsvH2V0= X-Forefront-PRVS: 0630013541 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(39380400002)(396003)(39850400004)(376002)(346002)(189003)(199004)(65826007)(65956001)(3846002)(6116002)(305945005)(72206003)(2616005)(7736002)(11346002)(66066001)(966005)(486005)(65806001)(47776003)(478600001)(446003)(476003)(486005)(31686004)(6486002)(86152003)(53546011)(6306002)(68736007)(117156002)(26005)(956004)(5660300001)(36756003)(42882007)(316002)(53376002)(6246003)(386003)(4326008)(25786009)(2906002)(16576012)(50466002)(53936002)(58126008)(230700001)(59450400001)(229853002)(16526019)(31696002)(186003)(8656006)(110136005)(54906003)(8936002)(106356001)(64126003)(77096007)(105586002)(52146003)(2486003)(52116002)(23676004)(81166006)(8676002)(81156014)(6666003)(97736004)(76176011)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1903; H:[192.168.0.106]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA3MDFNQjE5MDM7MjM6U0pxYytEVmR3eEwrMkJWV3Zhb1VkM0Qw?= =?utf-8?B?ZENPYVRLYVErZ2J5SzlMTzBJZTh3UlpGcWdVbVNpTjVnYW1tRE5ieUc5QmIv?= =?utf-8?B?SG0yclJrT0pwb2xaeGdzcTNmdTVaMVVUVjN5U00wZ0E5bGZ2dUpmNkNrT2ti?= =?utf-8?B?aXNlcUp2WjQ0Smh5Q3VCN0J6cUs0QjZGZFFtR2ttZWd6SmxIZm4xYUluVnkv?= =?utf-8?B?Wm1OSWh2MVdpWkptelBrYllpL3czZzBpZ1MzL0ZmSXRuc3JxY3NPTm8rL25z?= =?utf-8?B?TG5XZ3c3M0lBUnp0UE1wSjlkTUt2MWpFbjF4alQwOXJ0YjhQRmI3dGw3VU5F?= =?utf-8?B?U21yZGdsNjJ3WWpRKzA1UVlvbHVTV2pvUDdCckoxOFZrazlCallVYzZINzJ4?= =?utf-8?B?bzhNRThVTkV0TXdZT0pmN0Uxd25DZDBxaVBFbFFPdlJNSU5tVWZsQ3ovVWNS?= =?utf-8?B?QnBtNmtiSG0zTW5FNndNVUpVMWNSVGlGNHpaSDJXdC9odmhwckZ2MDhYM0s3?= =?utf-8?B?Rk9lejdrQThqaXRhRXIvTU4vN2V3ajdnei8vMVEvdTBlWUhaaDNHaFVmOUFP?= =?utf-8?B?NkwzbU9uOXh2WGMvUHZ5QjFCVGhsQTBxN1BsQllyVG12VkExNE81cE40WDhX?= =?utf-8?B?aTc2dnZ1cUxhMG1IS01PZlI5VUZuVmtnRE5tbkVydUhkWXBzUzh1SVpLeFZW?= =?utf-8?B?MHZBQnNMRjJLdEs1Rzc4Sy9WMDBlOEZwOFc3MWRCeTBzU3RySkUrdEYwM2dU?= =?utf-8?B?U2lEQS9kOHhCWXhXb2w5MXRDaVFHWXVCSHkwWmpHOG5yS2ZMeGthUXNRZTl3?= =?utf-8?B?UVQwU2FiZ0FKVThSR2JSb2kxOGhGMGd0OVVsUnFWSFQ5eTUzVVZrRW0yV2xU?= =?utf-8?B?VE9ZYUJxZGlqSXBpUVYvT254akVsTkxWaG9XRklMdVNvYUlTV0dva1JES1Mr?= =?utf-8?B?d2xuQkdKZGZQNkhPZTJ6REJPbnlqRjZrTmFQN2p0R1MwOStOUFY2VHBaNGRU?= =?utf-8?B?T2w5a05xc0JjUzRueStyaU95dk1CQmQ3T2prRlNvS3FTY0U5REVnM1kwNnl3?= =?utf-8?B?bzRDeURLaHpjNWxrK1NYK3BrcWR6NnQ3blplV2JlL2RoZHZ0YmhQa1J1YVUr?= =?utf-8?B?NGJGcjNodkR3MS9JRnhFTXpQUFQ1Um9vNCtHZ1BMQllkelFZT3BvZkE5cG5B?= =?utf-8?B?NWpZM2toZHM5aHBIK1NqblUrWStHemJGbUJNS2lOYmN5Y0xuZjhwSkdXT010?= =?utf-8?B?cHpsWW9ZdlQ0YlFlSXJtUjZBbVg4VnhjTFdMWmF4ZTZXV2Y2K1BaUFVITnJU?= =?utf-8?B?Q1JaV2hQY3V0ZVhjc3BXMWVnYk9HM0FLMTF4a0tVM1JwQTIrR2xSaDR4VDNF?= =?utf-8?B?bUtTcFZaT2x3MytidWtQTWkxbkllY3d1c1V1U1BrY0lMRTlCWXhNUnIzSURE?= =?utf-8?B?TUFlSFhQN1Z5SnhabWtuU1czdzBDT1hEVExoaDl6RVlXazZNb09TNnFneXF1?= =?utf-8?B?aHBRTm9DYm15cVdtRFQvSFltTnJSUFFCZG50NTZ5QWN3aUN3c3JBcWMvNHNS?= =?utf-8?B?UjluUG1lYTZlMGZydjdxUTdtdjB0dWxKbmVhREhCKy91aEdqdDRESWVwQTRC?= =?utf-8?B?TFV1R1YzT0V1NGlsUXBqU0I5eTBhbDVwc1o5N2o3Ykp4ODFvT1ZtVjdXdm5E?= =?utf-8?B?UmFJcy9NWm5PNEhKTHpLUi84SCtrb1Iyc0hWQUcxT0xUc3NIbGF0TFZaK05l?= =?utf-8?B?U2VIL3RnVjJrUE5rUWNGQjhDS3VSZURUc2hDWG9Ibkt2ZnAvUEdSWm15WHY2?= =?utf-8?B?ZmZCQjVPY0k0V1ZWMlYvemxaVElMWFR5TXBLRjVTOXhtb1dVak5uYWZYb3lN?= =?utf-8?B?dVlQTW1XUC9yWGNDSTVHSG0rNkNzbWNVV0VxVUhJSGx5MEhTNWhsLzdMR0cy?= =?utf-8?B?REUrL3IvVnNCNW5nMVlsVDJ5a240WFR6U1dyL2tYcXZhUi9YMjBaVjVUTEU3?= =?utf-8?B?TTNGcjFQSlFtN1hSRE0ySDQxSS9VS09KK3dRZ1YrRUZ3NDU3MkhIKzRZNWFo?= =?utf-8?B?ekNaOXhLRzJ0QkhkZVhKa1RQWTRkVFd4M09PaTR4UWlHb2RlRHZCeG9HSXRz?= =?utf-8?B?b0ZpM2NmTWRHd3AzV05TbDRsaDA0R0xCdjEvYWxUbU8rZjFaS2JwMkViMnJB?= =?utf-8?Q?0cTxFZeqZXvxmMgURW/7wNlB+soH07OWLrycSQU/Jfjo=3D?= X-Microsoft-Antispam-Message-Info: WjWX9FukCeNcan0WfHIgmVLZpxn9vcG7maWGnAEOFRoE5A+zlZ4lpWsRwUuIARGzw2m2TQaZlnDvVAkEJCjlnKCtTNvvVxER96bL+IWjFLDYBqCTb8DArtBFF4FcLi7e5JGgSiDN8aJnsDbBw1R0QPcIxd+W+9KzoWMNiYPs6tUTQyVhUc39R/PVz55Y+w16 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 6:i1A4aPkF84sGAhV9n9iRN4GEwv+9r/qwm91LCdVmKiO/H/lBCmIcW34fzJXlqfFviV3keN4KC0cIw7qqahkJuJWDYg+l23r2aa/FVMO/PkZhYWkxArd9VEFIS9QFI9T8XjKQ64Bz2QGk+ylCDr19OfEczdsgh8BcAi8c+Iw+6TWHdVq1h950q6juNceYqImTFpTCUa95qDcF6Fbut39lQ7+iqm3Ad49n42g7SWZ4nidmZnf13VT6byITxit7vFKP+9VTt/DrKK81qEBD8zITqHNkRp031WyCfVdq5f/mxFCodmaCyJ3muJHaokQylIcioWghfDRBhYYgKRrM9VGqDVeZGYZn9v54hoE0qKY94J8Tbti0W1i1TPDuka9oTeEModD1A5Y5ttYv8kqg7YtjGkyLG0sMDYY4Zi6c3r+RjD6h2BmBLO8R6Q4I4rclUqyKjc+miIcXpfCmmgMyvMOcfA==; 5:kBoRpUYkVgS5IM1DAKYuj9/quulo4ZFKwy9mkvMmedyFTGtHp8h2BE/XQJDpDtsWp9/U1l8b3CkhD7RAqShnnXiXdfX8X/8EWC/38ci27UUqcHzbgZ06PwZ6X/x0ZUtCeC289GxF09zdDTv9Rqk1aZQgqN27hMUQNsMgGMFcGSg=; 24:QEXiIFGx5OUMsvuhVJ7VcKXy3uIkWYkXD8W3+DWE1LctRHhyXTPUK2Sr7mcZHZIWwN2aBmHpFsihucfOV+gMiAGHsBqOubbzOsRf9DqoytQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 7:IqNpXgAUWQnt8T2dPifkHMk9ZtKYO6N5ndoId5yv1oS1sejZPGRlaZop7ejauhuwOhvItPSS3z9keofCRd2glIUXXd/wmBlQAAyzrrJVmSfZfqzlinurh6TXdoarb4K23QmzZ8RzbqIYPTYxefESVG6eCB+jAGgji2U1sdWfghtBmQ32zfCajcta3CvuR/nDaaslmaIk9XC4wJ97CCuhbUQM1uV7jjNk4nPvnvq6phpfGhiHY7/QoTV6wcW/Y/1H X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2018 16:13:40.5181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 294b5b86-1663-479c-1aaa-08d598b4b456 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1903 Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 16:13:45 -0000 Hello David, On Friday 30 March 2018 08:59 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with generic device struct and updating >> places that are using pci device in a way to get this information from >> generic device. >> >> Signed-off-by: Ferruh Yigit > [snip] > >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 209796d46..68bdc3103 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -2421,6 +2421,7 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) >> memset(dev_info, 0, sizeof(struct rte_eth_dev_info)); >> dev_info->rx_desc_lim = lim; >> dev_info->tx_desc_lim = lim; >> + dev_info->device = dev->device; >> >> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >> (*dev->dev_ops->dev_infos_get)(dev, dev_info); > Reviewed-by: David Marchand > > Just a little comment, do we want the pmd to be able to override this ? > > I can see we enforce the driver name by putting it after the call to > .dev_infos_get. > http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.c#n2399 > > octeontx pmd seems to try to do something about it: > http://dpdk.org/browse/dpdk/tree/drivers/net/octeontx/octeontx_ethdev.c#n622 > > Not sure it does something, might be a thing to cleanup. > > In case, if your referring to driver_name update then indeed its a cleanup [1]. Otherwise, I don't see any issue with v4 Or may be /I /misunderstood your comment. Thanks. [1] http://dpdk.org/dev/patchwork/patch/36880/