DPDK patches and discussions
 help / color / mirror / Atom feed
From: "humin (Q)" <humin29@huawei.com>
To: Ke Zhang <ke1x.zhang@intel.com>, <chas3@att.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH] app/test: fix LACP handshake overtime
Date: Fri, 23 Sep 2022 08:58:14 +0800	[thread overview]
Message-ID: <0842a632-91f7-2928-b289-c3985d43c67c@huawei.com> (raw)
In-Reply-To: <20220818054341.93517-1-ke1x.zhang@intel.com>

Hi, Zhang,

     Why LACP handshake "overtime" in your test?

     Maybe in other occasions, 60 * delay is also not enough.

     BTW, how about config "conf.update_timeout_ms" for the test?

在 2022/8/18 13:43, Ke Zhang 写道:
> Increase the loop count so that there is a longer
> threshold time for the LACP handshake process.
>
> Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
>   app/test/test_link_bonding_mode4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c
> index d9b9c323c7..bfdd18cdd1 100644
> --- a/app/test/test_link_bonding_mode4.c
> +++ b/app/test/test_link_bonding_mode4.c
> @@ -613,7 +613,7 @@ bond_handshake(void)
>   
>   	/* Exchange LACP frames */
>   	all_slaves_done = 0;
> -	for (i = 0; i < 30 && all_slaves_done == 0; ++i) {
> +	for (i = 0; i < 60 && all_slaves_done == 0; ++i) {
>   		rte_delay_ms(delay);
>   
>   		all_slaves_done = 1;

  reply	other threads:[~2022-09-23  0:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18  5:43 Ke Zhang
2022-09-23  0:58 ` humin (Q) [this message]
2022-09-30  1:27   ` Zhang, Ke1X
2022-10-21  7:33     ` Zhang, Ke1X
2024-04-17 10:25 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0842a632-91f7-2928-b289-c3985d43c67c@huawei.com \
    --to=humin29@huawei.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=ke1x.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).