From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAC8FA054A; Fri, 23 Sep 2022 02:58:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B891400D7; Fri, 23 Sep 2022 02:58:19 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 59FF94003C; Fri, 23 Sep 2022 02:58:17 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MYYcM5C6XzHqPB; Fri, 23 Sep 2022 08:56:03 +0800 (CST) Received: from [10.78.23.197] (10.78.23.197) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 08:58:14 +0800 Message-ID: <0842a632-91f7-2928-b289-c3985d43c67c@huawei.com> Date: Fri, 23 Sep 2022 08:58:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] app/test: fix LACP handshake overtime To: Ke Zhang , , CC: References: <20220818054341.93517-1-ke1x.zhang@intel.com> From: "humin (Q)" In-Reply-To: <20220818054341.93517-1-ke1x.zhang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.23.197] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Zhang,     Why LACP handshake "overtime" in your test?     Maybe in other occasions, 60 * delay is also not enough.     BTW, how about config "conf.update_timeout_ms" for the test? 在 2022/8/18 13:43, Ke Zhang 写道: > Increase the loop count so that there is a longer > threshold time for the LACP handshake process. > > Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") > Cc: stable@dpdk.org > > Signed-off-by: Ke Zhang > --- > app/test/test_link_bonding_mode4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c > index d9b9c323c7..bfdd18cdd1 100644 > --- a/app/test/test_link_bonding_mode4.c > +++ b/app/test/test_link_bonding_mode4.c > @@ -613,7 +613,7 @@ bond_handshake(void) > > /* Exchange LACP frames */ > all_slaves_done = 0; > - for (i = 0; i < 30 && all_slaves_done == 0; ++i) { > + for (i = 0; i < 60 && all_slaves_done == 0; ++i) { > rte_delay_ms(delay); > > all_slaves_done = 1;