From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB5FAA09F0; Wed, 16 Dec 2020 19:46:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22228C9C8; Wed, 16 Dec 2020 19:46:16 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 5BE8BC9BC for ; Wed, 16 Dec 2020 19:46:15 +0100 (CET) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0BGIW6pf081702; Wed, 16 Dec 2020 13:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=3ZTDH6NTXei2/tp4NGPA7e4b7vqy7FrH1puUpKFhcek=; b=ON/L6WhHozeF1mUgRCfGnieQuyUQ1hlCJ47A8PYd/48PqkCOQrbwKFV/9lviHXX0TJ/K ciOQyphaFqwlJpuav+yDBA1aLKting2dW8p9nUBoJc83ZESzIMNHXrZ+MzS80w/HuqEK +mKhtpLLd2gIoVG2XM3ZO+kP3x9edYgTaazWLIgGRZpVhVKTbVNQq2B8M7sLQuLK8pfO vU7HN06G33sYGDZj0rW5fiqQ69ZKak3ZkvvxSC4ULxOc0ERe+NYhZ5m6PO5FAavMtmO4 w2cEFqKp49MxVooyA6X7TDDehiSnsHaiG1i0GqWszrlLuDPsUlCMVtUo7QEG2O0G7dCx bA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 35fp0bkgwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Dec 2020 13:46:04 -0500 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0BGIWbco083273; Wed, 16 Dec 2020 13:46:03 -0500 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 35fp0bkgvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Dec 2020 13:46:02 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0BGIarw6016203; Wed, 16 Dec 2020 18:46:01 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma02dal.us.ibm.com with ESMTP id 35d5264gh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Dec 2020 18:46:01 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0BGIk0GY26280248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Dec 2020 18:46:00 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87B516E053; Wed, 16 Dec 2020 18:46:00 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD54C6E052; Wed, 16 Dec 2020 18:45:59 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.51.198]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 16 Dec 2020 18:45:59 +0000 (GMT) To: Bruce Richardson , dev@dpdk.org Cc: bluca@debian.org, david.marchand@redhat.com, ian.stokes@intel.com, Ilya Maximets , Jerin Jacob , Ruifeng Wang , Honnappa Nagarahalli References: <20201211155111.145279-1-bruce.richardson@intel.com> From: David Christensen Message-ID: <084428f5-c393-a744-6af8-062887cb40d1@linux.vnet.ibm.com> Date: Wed, 16 Dec 2020 10:45:59 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201211155111.145279-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-16_07:2020-12-15, 2020-12-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 clxscore=1011 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012160115 Subject: Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/11/20 7:51 AM, Bruce Richardson wrote: > Traditionally any apps built using DPDK had to support the same > instruction sets as supported when the DPDK SDK itself was built, since > that was "leaked" through to the end-app and DPDK headers via > RTE_MACHINE_CPUFLAG_* values. Therefore, when converting over to meson > for app build correctness the "-march=" flag was included in the > pkg-config cflags output. > > However, since the DPDK-specific CPU flags are now obsolete, and we > instead check directly for compiler-defined flags, we should no longer > need to force the exact same architecture match in all cases. To > faciliate such flexibility, a new pkg_config_machine_args array - which > defaults to the existing machine_args array has been defined. The > individual architectures - x86, arm and ppc - can choose if and how to > override this value themselves. > > For x86, since SSE4.2 is the minimum instruction-set level needed to run > DPDK, and since some header files assume that minimum level of > instruction set support, we override the "-march=" value with "-msse4" > for the pkg-config file. This allows end applications to set their own > "march" value while still ensuring valid DPDK compilation. > > Signed-off-by: Bruce Richardson > --- > > CC: Jerin Jacob > CC: Ruifeng Wang > CC: Honnappa Nagarahalli > CC: David Christensen > Feedback requested from ARM and PPC maintainers as to this change > and what flags, if any, need to be in the .pc file for DPDK on such > platforms. For example - is setting 'pkg_config_machine_args' to > 'machine_args' by default necessary behaviour? Support for Altivec would be the equivalent here for PPC and I'm not aware of any additional flags required for supported POWER CPUs on DPDK. I can't speak to P10 requirements yet but the proposed change is a don't care for me. Dave