From: Kevin Traynor <ktraynor@redhat.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wang, Liang-min" <liang-min.wang@intel.com>,
"daniels@research.att.com" <daniels@research.att.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf
Date: Fri, 7 Jun 2019 15:38:13 +0100 [thread overview]
Message-ID: <086dc777-022b-db04-143c-9c29d5ed7903@redhat.com> (raw)
In-Reply-To: <E3B9F2FDCB65864C82CD632F23D8AB87733707DE@SHSMSX101.ccr.corp.intel.com>
On 07/06/2019 14:55, Wang, Haiyue wrote:
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Friday, June 7, 2019 20:25
>> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Lu,
>> Wenzhuo <wenzhuo.lu@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>; daniels@research.att.com
>> Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf
>>
>> On 07/06/2019 04:10, Haiyue Wang wrote:
>>> Add the detail description for this pflink_fullchk option, when it will
>>> be used, and it is used for fixing what kind of issue.
>>>
>>
>> You can squash the docs into the 1/2 patch.
>>
> Yes, I've sent a single patch before: https://patches.dpdk.org/patch/54374/
> After some quiet time, I found that most of commits about doc are a single
> patch, so I split it into two.
>
Personally I don't have an issue either way, but docs with code is the
preferred method for DPDK so you could squash if you are doing a v2.
>>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>>> ---
>>> doc/guides/nics/ixgbe.rst | 18 ++++++++++++++++++
>>> 1 file changed, 18 insertions(+)
>>>
>>> diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
>>> index 975143f..33812a5 100644
>>> --- a/doc/guides/nics/ixgbe.rst
>>> +++ b/doc/guides/nics/ixgbe.rst
>>> @@ -82,6 +82,24 @@ To guarantee the constraint, capabilities in dev_conf.rxmode.offloads will be ch
>>>
>>> fdir_conf->mode will also be checked.
>>>
>>> +VF Runtime Options
>>> +^^^^^^^^^^^^^^^^^^
>>> +
>>> +The following ``devargs`` options can be enabled at runtime. They must
>>> +be passed as part of EAL arguments. For example,
>>> +
>>> +.. code-block:: console
>>> +
>>> + testpmd -w af:10.0,pflink_fullchk=1 -- -i
>>> +
>>> +- ``pflink_fullchk`` (default **0**)
>>> +
>>> + Toggle behavior to get ixgbevf link status quickly by checking the
>>> + mailbox status or not. If set, the VF will check the PF's link status
>>> + and the PF's mailbox running status, which will trigger PF's mailbox
>>> + interrupt generation. Otherwise, just check PF's link status, then no
>>> + mailbox interrupt in PF.
>>> +
>>
>> wait_to_complete is also considered, so doesn't it mean that
>> pflink_fullck is not a toggle in all cases e.g. rte_eth_link_get() will
>> set wait_to_complete=1 and then pflink_fullchk is ignored. At least you
>> should mention if there is some user visible API like this where the
>> flag will not result in the behaviour being toggled.
>>
>
> I use "get ixgbevf link status -quickly-" to describe "wait_to_complete = 0",
> maybe I need some code to make the information more clear.
>
I think all you need to add is that rte_eth_link_get() will still use
the mailbox method regardless of the pflink_fullchk setting, but maybe
there's more I haven't considered wrt testpmd.
>>> RX Burst Size
>>> ^^^^^^^^^^^^^
>>>
>>>
>
next prev parent reply other threads:[~2019-06-07 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 3:10 [dpdk-dev] [PATCH v1 1/2] net/ixgbevf: add an option pflink_fullchk to get link status quickly Haiyue Wang
2019-06-07 3:10 ` [dpdk-dev] [PATCH v1 2/2] doc: add the description for option pflink_fullchk in ixgbevf Haiyue Wang
2019-06-07 3:10 ` [dpdk-dev] [PATCH 1/2] net/ixgbevf: add an option pflink_fullchk to get link status quickly Haiyue Wang
2019-06-07 3:10 ` [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf Haiyue Wang
2019-06-07 11:31 ` Scott Daniels
2019-06-07 12:25 ` Kevin Traynor
2019-06-07 13:55 ` Wang, Haiyue
2019-06-07 14:38 ` Kevin Traynor [this message]
2019-06-07 15:10 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=086dc777-022b-db04-143c-9c29d5ed7903@redhat.com \
--to=ktraynor@redhat.com \
--cc=daniels@research.att.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=liang-min.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).