From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A308943739; Tue, 19 Dec 2023 13:05:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 929E742DFD; Tue, 19 Dec 2023 13:05:39 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 93B3E40283; Tue, 19 Dec 2023 13:05:37 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Svb2r2Kcwz6JB84; Tue, 19 Dec 2023 20:04:20 +0800 (CST) Received: from frapeml100007.china.huawei.com (unknown [7.182.85.133]) by mail.maildlp.com (Postfix) with ESMTPS id B7C3B140390; Tue, 19 Dec 2023 20:05:36 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100007.china.huawei.com (7.182.85.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Dec 2023 13:05:36 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.035; Tue, 19 Dec 2023 13:05:36 +0100 From: Konstantin Ananyev To: Sivaprasad Tummala , "david.hunt@intel.com" , "anatoly.burakov@intel.com" , "jerinj@marvell.com" , "radu.nicolau@intel.com" , "gakhil@marvell.com" , "cristian.dumitrescu@intel.com" , "ferruh.yigit@amd.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction Thread-Topic: [PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction Thread-Index: AQHaMiuEVTKpsBDLF0CQ9pPlPVi3J7CwguIw Date: Tue, 19 Dec 2023 12:05:36 +0000 Message-ID: <0897bc70dd984126a02c3f5046495c1c@huawei.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> <20231219032826.4814-2-sivaprasad.tummala@amd.com> In-Reply-To: <20231219032826.4814-2-sivaprasad.tummala@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Currently the config option allows lcore IDs up to 255, > irrespective of RTE_MAX_LCORES and needs to be fixed. >=20 > The patch allows config options based on DPDK config. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Sivaprasad Tummala > --- > examples/l3fwd/main.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) >=20 > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 3bf28aec0c..ed116da09c 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -99,7 +99,7 @@ struct parm_cfg parm_config; > struct lcore_params { > uint16_t port_id; > uint8_t queue_id; > - uint8_t lcore_id; > + uint16_t lcore_id; > } __rte_cache_aligned; >=20 > static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; > @@ -292,8 +292,8 @@ setup_l3fwd_lookup_tables(void) > static int > check_lcore_params(void) > { > - uint8_t queue, lcore; > - uint16_t i; > + uint8_t queue; > + uint16_t i, lcore; > int socketid; >=20 > for (i =3D 0; i < nb_lcore_params; ++i) { > @@ -304,12 +304,12 @@ check_lcore_params(void) > } > lcore =3D lcore_params[i].lcore_id; > if (!rte_lcore_is_enabled(lcore)) { > - printf("error: lcore %hhu is not enabled in lcore mask\n", lcore); > + printf("error: lcore %hu is not enabled in lcore mask\n", lcore); > return -1; > } > if ((socketid =3D rte_lcore_to_socket_id(lcore) !=3D 0) && > (numa_on =3D=3D 0)) { > - printf("warning: lcore %hhu is on socket %d with numa off \n", > + printf("warning: lcore %hu is on socket %d with numa off\n", > lcore, socketid); > } > } > @@ -359,7 +359,7 @@ static int > init_lcore_rx_queues(void) > { > uint16_t i, nb_rx_queue; > - uint8_t lcore; > + uint16_t lcore; >=20 > for (i =3D 0; i < nb_lcore_params; ++i) { > lcore =3D lcore_params[i].lcore_id; > @@ -500,6 +500,8 @@ parse_config(const char *q_arg) > char *str_fld[_NUM_FLD]; > int i; > unsigned size; > + unsigned int max_fld[_NUM_FLD] =3D {RTE_MAX_ETHPORTS, > + 255, RTE_MAX_LCORE}; >=20 > nb_lcore_params =3D 0; >=20 > @@ -518,7 +520,8 @@ parse_config(const char *q_arg) > for (i =3D 0; i < _NUM_FLD; i++){ > errno =3D 0; > int_fld[i] =3D strtoul(str_fld[i], &end, 0); > - if (errno !=3D 0 || end =3D=3D str_fld[i] || int_fld[i] > 255) > + if (errno !=3D 0 || end =3D=3D str_fld[i] || int_fld[i] > > + max_fld[i]) > return -1; > } > if (nb_lcore_params >=3D MAX_LCORE_PARAMS) { > @@ -531,7 +534,7 @@ parse_config(const char *q_arg) > lcore_params_array[nb_lcore_params].queue_id =3D > (uint8_t)int_fld[FLD_QUEUE]; > lcore_params_array[nb_lcore_params].lcore_id =3D > - (uint8_t)int_fld[FLD_LCORE]; > + (uint16_t)int_fld[FLD_LCORE]; > ++nb_lcore_params; > } > lcore_params =3D lcore_params_array; > -- Acked-by: Konstantin Ananyev =20 > 2.25.1