From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "David Marchand" <david.marchand@redhat.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
stable@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v1 1/1] eal/random: fix random state initialization for non-eal threads
Date: Wed, 4 Oct 2023 12:37:43 +0100 [thread overview]
Message-ID: <08992987-4fe0-1759-aad6-490f0078d9f3@intel.com> (raw)
In-Reply-To: <CAJFAV8yST4hj8yJ1E83ANNYt2ZWGhseG48KqQ+6SigjibqsmtA@mail.gmail.com>
On 10/2/2023 9:25 AM, David Marchand wrote:
> Hello guys,
>
> On Mon, Aug 28, 2023 at 2:07 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> Currently, the rte_rand() state is initialized with seed, and each
>> rand state is initialized up until RTE_MAX_LCORE'th rand state. However,
>> rand state also has one extra rand state reserved for non-EAL threads,
>> which is not initialized. Fix it by initializing this extra state.
>>
>> Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR")
>> Cc: mattias.ronnblom@ericsson.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> We have two series for fixing related issues.
>
> Stephen alternative patch 1 handles Anatoly fix here.
> https://patchwork.dpdk.org/project/dpdk/list/?series=29449&state=%2A&archive=both
>
> I see Anatoly was acked by Mattias and Morten, though Stephen
> (RTE_DIM) fix is more elegant.
> How do you guys want me to proceed?
>
>
> Thanks.
I'm OK with either, so please feel free to merge Stephen's patch :)
--
Thanks,
Anatoly
prev parent reply other threads:[~2023-10-04 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 12:06 Anatoly Burakov
2023-08-28 12:22 ` Mattias Rönnblom
2023-08-28 12:48 ` Morten Brørup
2023-10-02 8:25 ` David Marchand
2023-10-02 9:02 ` Morten Brørup
2023-10-02 12:22 ` Mattias Rönnblom
2023-10-04 11:37 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08992987-4fe0-1759-aad6-490f0078d9f3@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).