From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F86CA0C41; Wed, 6 Oct 2021 18:46:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5863140696; Wed, 6 Oct 2021 18:46:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8B5CD40685 for ; Wed, 6 Oct 2021 18:46:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19695jk5019417; Wed, 6 Oct 2021 09:46:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=x7Xpil1EYSOXbWUznoQqfpCr8TzPllv/mZW56vdbmY8=; b=bUl9sGV1fVDpO1tPtUaGlQBstECqwA4wKdB+SLutAkMjMUpVYm4aFrJ3Fmye1hFk4ywr S4SDLqHNLnFQYueiQB3lpXFIkfE6FmdLUIYDMhTITaisgoGzigedmlcjCSC6ldSPRloZ 8nOvTHAKYp0aEQMCikBySzEochQNys3PtXPt7VU6UZGEmUSnUhoIeLPhOb7O9g1q3wzV ctPd0EyIFVOWno6btMRD+TrsjKXTU4C43uX0S/5RUrW1veT5N3ShBOIsXgNpngVlGnYu 7IDgKyD+U4yfhjWylkcQ02+Z5YWkRUo+yfTpLZyAf+u3EWjMVtNUEvsRuph8mdt6CiFl AQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 3bh8v3t0u1-15 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Oct 2021 09:46:06 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 6 Oct 2021 09:44:27 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 6 Oct 2021 09:44:27 -0700 Received: from [10.28.175.194] (PE-LT1350.marvell.com [10.28.175.194]) by maili.marvell.com (Postfix) with ESMTP id 3E0573F7040; Wed, 6 Oct 2021 09:44:23 -0700 (PDT) To: Ferruh Yigit , , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Ray Kinsella , Anatoly Burakov CC: References: <20210902021505.17607-1-ndabilpuram@marvell.com> <20211001134022.22700-1-ndabilpuram@marvell.com> <20211001134022.22700-17-ndabilpuram@marvell.com> <8b7209ab-775d-606b-a6b1-1cdbc349e97d@intel.com> From: Nithin Kumar Dabilpuram Message-ID: <08f0e3cc-6dff-cea4-29fd-eb16d61dbf0d@marvell.com> Date: Wed, 6 Oct 2021 22:14:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8b7209ab-775d-606b-a6b1-1cdbc349e97d@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ZNEHei0O49taovi4HDx-9LsYCT8Yb9MY X-Proofpoint-ORIG-GUID: ZNEHei0O49taovi4HDx-9LsYCT8Yb9MY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-06_04,2021-10-06_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v3 16/28] net/cnxk: support inline security setup for cn9k X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/6/21 9:51 PM, Ferruh Yigit wrote: > On 10/1/2021 2:40 PM, Nithin Dabilpuram wrote: >> +static int >> +nix_security_release(struct cnxk_eth_dev *dev) >> +{ >> +    struct rte_eth_dev *eth_dev = dev->eth_dev; >> +    struct cnxk_eth_sec_sess *eth_sec, *tvar; >> +    struct roc_nix *nix = &dev->nix; >> +    int rc, ret = 0; >> + >> +    /* Cleanup Inline inbound */ >> +    if (dev->rx_offloads & DEV_RX_OFFLOAD_SECURITY) { >> +        /* Destroy inbound sessions */ >> +        tvar = NULL; >> +        TAILQ_FOREACH_SAFE(eth_sec, &dev->inb.list, entry, tvar) >> +            cnxk_eth_sec_ops.session_destroy(eth_dev, >> +                             eth_sec->sess); >> + >> +        /* Clear lookup mem */ >> +        cnxk_nix_lookup_mem_sa_base_clear(dev); >> + >> +        rc = roc_nix_inl_inb_fini(nix); >> +        if (rc) >> +            plt_err("Failed to cleanup nix inline inb, rc=%d", rc); >> +        ret |= rc; >> +    } >> + >> +    /* Cleanup Inline outbound */ >> +    if (dev->tx_offloads & DEV_TX_OFFLOAD_SECURITY || >> +        dev->rx_offloads & DEV_RX_OFFLOAD_SECURITY) { >> +        /* Destroy outbound sessions */ >> +        tvar = NULL; >> +        TAILQ_FOREACH_SAFE(eth_sec, &dev->outb.list, entry, tvar) >> +            cnxk_eth_sec_ops.session_destroy(eth_dev, >> +                             eth_sec->sess); > > > Replacing 'TAILQ_FOREACH_SAFE' with 'RTE_TAILQ_FOREACH_SAFE' on > next-net, because of > following commit in the main repo: > > Commit f1f6ebc0eaf6 ("eal: remove sys/queue.h from public headers") Ack, Thanks.