Re: [dpdk-dev] [dpdk-stable] [PATCH] app/regex: avoid division by zero

["Min Hu (Connor)" <humin29@huawei.com>]

Hi, Thierry,
	This bug has been fixed in my earlier patch, please refer to:
https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-5-git-send-email-humin29@huawei.com/

	Thanks.


在 2021/5/24 16:57, Thierry Herbelot 写道:
> Check that nb_jobs is not zero before using it for a division.
> 
> Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> Cc: stable@dpdk.org
> Cc: Ori Kam <orika@nvidia.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>   app/test-regex/main.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> index 8e665df73ce0..8f48cab11924 100644
> --- a/app/test-regex/main.c
> +++ b/app/test-regex/main.c
> @@ -714,6 +714,8 @@ main(int argc, char **argv)
>   		rte_exit(EXIT_FAILURE, "Number of QPs must be greater than 0\n");
>   	if (nb_lcores == 0)
>   		rte_exit(EXIT_FAILURE, "Number of lcores must be greater than 0\n");
> +	if (nb_jobs == 0)
> +		rte_exit(EXIT_FAILURE, "Number of jobs must be greater than 0\n");
>   	if (distribute_qps_to_lcores(nb_lcores, nb_qps, &qps_per_lcore) < 0)
>   		rte_exit(EXIT_FAILURE, "Failed to distribute queues to lcores!\n");
>   	ret = init_port(&nb_max_payload, rules_file,
>