From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AA92A0C4B; Thu, 21 Oct 2021 12:13:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B2FA4116A; Thu, 21 Oct 2021 12:13:02 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 25252410E2 for ; Thu, 21 Oct 2021 12:13:01 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 721EA7F53A; Thu, 21 Oct 2021 13:13:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 721EA7F53A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634811180; bh=fDpqFQgzG9AQHktfLldEGz93rB4LlqrT68gwlO7YFwo=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=g9rTrOZrazDSh8e32I/N/qjDhlkvgBxmhPRjkBnH43T4/xHomm3l7PDlfmXLhevoP Br7WQsPaJNdYsCtSIvZdwqeVo6ONyKj+FsRLTo/IMWtuVP10F1o17h5/23CP+J+LzN BvH0Oa4IN0p3b87ku8en/qRCDj62gb5aM7ZOfi+8= To: Jie Wang , dev@dpdk.org Cc: orika@nvidia.com, ferruh.yigit@intel.com, thomas@monjalon.net, xiaoyun.li@intel.com, stevex.yang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, wenjun1.wu@intel.com, qi.z.zhang@intel.com References: <20211021062603.1549268-1-jie1x.wang@intel.com> <20211021100527.1582052-1-jie1x.wang@intel.com> <20211021100527.1582052-2-jie1x.wang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <08f49aa8-f135-8679-b3a1-e83b6290c04d@oktetlabs.ru> Date: Thu, 21 Oct 2021 13:13:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211021100527.1582052-2-jie1x.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 1/3] ethdev: support L2TPv2 and PPP procotol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/21 1:05 PM, Jie Wang wrote: > Added flow pattern items and header formats of L2TPv2 and PPP. > > Acked-by: Ori Kam Acks should go after Signed-off-by. > Signed-off-by: Wenjun Wu > Signed-off-by: Jie Wang with a couple of nits fixed Acked-by: Andrew Rybchenko [snip] > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 64ed7f2618..300e99e16b 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h [snip] > @@ -1900,6 +1916,55 @@ static const struct rte_flow_item_ethdev rte_flow_item_ethdev_mask = { > }; > #endif > > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice Empty line is required between EXPERIMENTAL and item name. > + * RTE_FLOW_ITEM_TYPE_L2TPV2 > + * > + * Matches L2TPv2 Header > + */ > +struct rte_flow_item_l2tpv2 { > + struct rte_l2tpv2_combined_msg_hdr hdr; > +}; > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_L2TPV2. */ > +#ifndef __cplusplus > +static const struct rte_flow_item_l2tpv2 rte_flow_item_l2tpv2_mask = { > + /* > + * flags and version bit mask > + * 7 6 5 4 3 2 1 0 7 6 5 4 3 2 1 0 > + * T L x x S x O P x x x x V V V V > + */ > + .hdr = { > + .common = { > + .flags_version = RTE_BE16(0xcb0f), > + }, > + }, > +}; > +#endif > + > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice here too [snip]