From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D551DA0542; Tue, 4 Oct 2022 19:51:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C71FE40DFB; Tue, 4 Oct 2022 19:51:30 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062.outbound.protection.outlook.com [40.107.101.62]) by mails.dpdk.org (Postfix) with ESMTP id D007540DDC for ; Tue, 4 Oct 2022 19:51:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PD4CdugcYrLoWW4plbHmJlXKIKvYpVGW+xnmD8GQwVQOc+o5HCMs4ngslqlX4LikAawdkBh2JDzrCCl04x1LaNze0t7jzLDA1YTPzI7obnmbFXZWeF+x2bMXiBVvFId1HzpEj3nm5apBTClStJv9XSkquObaMm2JLqk7T2NXYZ3nQGBVD7X//hMeSEV+JnNP4GiQEtA/ppoRSVNLcGzJzFg2NB5frIVa0sGIC/qS2/50EQVODkjIcAUu8o7S91POk0WVE/I+kWiBusP0o8WBVw/Wo70r8Xf5ryOAOmtk9BZMeRUU5cpGQfWglDX9kavCE3VpTfgUrYhs1KxkQDqLQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZpuYk6MnltPN8Ev8E4fXMaw7YNgJnDzpXRBr7B1fDQM=; b=c97+n7aWC5Utuve707f3u7LnqknyDnPDGxZfAEP/Yu7QEUqI5kO0QTie1Mgs1oMbXy+rT2Xo90sxyKkOlKSMM1fAULHq7/s+gtgeopt6e9EpYFre1dEht2kpCSU9U/eeTehHWXGNVnhAp1Gi5m55eE10DIRXpTMD3elcvEXCooYnosc+0RPsvLuvO0P6A5Q2v5o2dZ6cTf9jftPeS3NqGv/fgDsTEj6ACXgbswFEueRi0iKBvjEl6gprbcHtDKHoGJ5e298cwwB43zVXSEM2KWAv78yN9VkkDv6fxNtgbOBLcBPJGpcDw7COEGbsHMuq10yT2uvlcA/2fxhIX6vPDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZpuYk6MnltPN8Ev8E4fXMaw7YNgJnDzpXRBr7B1fDQM=; b=ntXnbxj/yRNw0u62oHfrD9LUSBbxs4Eltw5T3Jzas+wcYigkS61QUMKcmt/K0veDkfvLYWssAMsOr4J6ZTt3M6S48OOEUTVVZl2GxuiL+WqlsjK4PEB+Xq6YCy6wbNhCcE4jnmebd/WIe08ZdUj1EtfLhEBaQSxrIMda6kH+7b4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6257.namprd12.prod.outlook.com (2603:10b6:208:3e7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 17:51:25 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 17:51:25 +0000 Message-ID: <09656c03-8c4f-6550-dc7a-6b70568e798c@amd.com> Date: Tue, 4 Oct 2022 18:51:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Content-Language: en-US To: longli@microsoft.com Cc: dev@dpdk.org, Ajay Sharma , Stephen Hemminger References: <1662674189-29524-1-git-send-email-longli@linuxonhyperv.com> <1663987546-15982-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1663987546-15982-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6257:EE_ X-MS-Office365-Filtering-Correlation-Id: 315e1106-e298-45d4-7caa-08daa6310e5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jr4CBJpgPubEI99DmCWV75yTBqbZiPOsv8YAougjZZb8/ZPLMF6YP7ImrmKFtAa5jInlMpUqGv5b7HFeNQe8U0wKdOg/17FwifI6qVowSoNb+7JpF3Uqc74bLQNIY8lkWYSznfwIAkpHSqlGiIHv6XPE5XDscwVVsgteqDGnGmnpm+JTwBlR1ylQSJ0MlkE4Ouj302hiJVa+LGkNJQGh1O0bE6+AwYSd6oesMnDlUwKoRQTc6N4Z+9WiXa7Ml21S0wfUA7X+HM5/JZ9tCqLyD6CQ8O7dCwttlq9FnW3qcpz1haByRVfmEfBRPFptH6+R7nYzsYq7wwb39AWstkpMV4AoNc/zxAfl3PlcSDr2eE/e0myVbsdAoMaUYxAreMvzpUJJSqtmfD7V539ilc5aAV/POYtalBaBDceC1lAuhOeAsIkPpZuVHbn3HVCIITGQl/QTJrQMlbwcPK+wM3JrvqxI9WNSPGUhinvQGyTA/ChGiy6k6hHT7/AkHrlfhj/7vHASpXF4m3myaamXXKDkSue+Iftgdi/QG4URdOYeG5dhPKuoSFmYOWu55XaJPbyJ5CTIWVuNzC1dfRTKQxHLE5QQVAcQzStgWC8QgHNcUa619h5mVCWebUvr5PYgrutMShzwjL498m15iFlGvE9e2eRBSOZCOb117NXMXUfwzF4fr3SgUVLU8Q5JxnrQGjHqq3dKIzz6uUXGwVDglntD0tW38IrupZPD6B/aO2XfM/4OqgG3DOBHVcByVvS1ULX5qJYYFeCjt+ZB1/NFSFW+FpWypgJLcWUhhJRpRMAwYjU7rfH5WijDYsgIB37efmO9dZps6Yp+Jp5UtG0snHFKyY+EjQ+BZDJFvzR95zN3gQA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(47530400004)(451199015)(45080400002)(966005)(186003)(6486002)(6506007)(478600001)(31696002)(52230400001)(83380400001)(6666004)(53546011)(6916009)(2906002)(5660300002)(54906003)(2616005)(6512007)(38100700002)(44832011)(4326008)(8676002)(66556008)(26005)(66946007)(66476007)(41300700001)(316002)(86362001)(8936002)(31686004)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NSs1bjFnQ29UdUpmZ3lpKzg1cTNHUkRzTlJiNlRraDJMeTBDdGRoK2dQNlYx?= =?utf-8?B?WWlta00vM05EOXNhTmxzQ003SUFIcG1PU0ltTVRtT21OOHBtYnRyaFZaK3FQ?= =?utf-8?B?WnNtRTRYczR6N2lnaXFzUDA1OXBNcDNYK1NjVThwSTdjc0VRcUN6T2M1K29o?= =?utf-8?B?cG9Rem9LYlhXcnJuNmlmaEU1WGJtUy9uMitMNkVOa0ZoNEVjNE1HYUwvaXJ5?= =?utf-8?B?bG9JdXR4NlU0dmRlOGlPeXRhS05URDNyUG1JaUJBVDJGdk9PakRvVkJZcWsw?= =?utf-8?B?cUFVaHhVQVpmR1hvUXNiLzFOL0x2TXpjcDVBcFBJTTJkSGdHWENCaVZnYXNP?= =?utf-8?B?cDArQWVIaDR1NXFSQ0NucUEyUXhDY29tQmQzNEo2NEhPOHl6L1c1eDZSb0RT?= =?utf-8?B?bC9lbW54WmtHV2F5d1VpSGdDV1hJSnhLWS9GbDVhYmd3YmFhZlljNnY5SVJO?= =?utf-8?B?WEsvTTFnblVPVGcvdkVDdytiTW4yWG55QjlGdmd1d3FHL1JoODQ5ZjlQeVlZ?= =?utf-8?B?aGhMdnFaNE8zay9zTm1YZ1duVFU0ZGZrWHRQeXE0VTNGdDJkOUFCWkxEUnNy?= =?utf-8?B?cDRKUWlQRU5xNXhWU0t3VHFWMFFkWjBTMU15VDRISkJETU1RUGVFM0VlbDJk?= =?utf-8?B?RTgxcncwR0VwWFNKVjVVQXVkTjQ2T3Vac0xhTlF6M2c2STdIMzllbm4yT3Rk?= =?utf-8?B?UDlleU9aZkNpYjdiLzl3Y1dudE9IYzY2VktYdUVLRWpkdXZ2V2Rvamt2ODdk?= =?utf-8?B?TGhMVlpsYVBIYmxVS0FNem5XVXJUd3NYRDViaFRnd1VQWklBcDZxSFJFNkdX?= =?utf-8?B?OHpMOEFsY2o2RjZXSGUrWnloTjNIcm1yTEF4NStqdnhQRVdDUk5NcW4rTWhk?= =?utf-8?B?ZnU4TkZ6QUo3U282Z2RKYWZCOHdOVWU4Q2dMRnIxYXZ4eTkyWnVVcXN3Z1hs?= =?utf-8?B?OUhYdjErR1VHMlpXN29XNXR6Qk5SMXRsU2RLQy9RSHpMQ2pPQmJwbXZ0Szlk?= =?utf-8?B?ZVpDc3ZHWW5oR1JSMlNrbmdsTjQvdHgrY2pTc3hLQnNBUG5wVE1rU09JeU9h?= =?utf-8?B?elBVN2pFaGFRZlZnMGVEQThjUW1EbWhZN0F2MHBIYm9zYXVFMWZJQVN5dDl3?= =?utf-8?B?MzRFSjR3VEE5VGJSK2ZxbnBUVDU1SytLd1JIcGlKMUNDWFFWWVQyeUNjeUs0?= =?utf-8?B?K1o4Wk5tdUQwNHZpVU82VjFpVXhFY3NISHowNHZyTmYrRXprUFdEaGZkVXhU?= =?utf-8?B?VVN5QVk5NW9Ed2Zuc3VwTFdrYWkxZy9mRjRDVmdNeWZ6M09HZTRzSU5jUHJH?= =?utf-8?B?MWRTZG9PSldBTGxKUGlISWJ3T0grTURRUUZXVTE0ditlS0JaQzVON21hOWlU?= =?utf-8?B?eVYyLytTSnoyQ2h5NFpwV29OcHEwMTBQazc4TXRJQXluWjJ2SDRjaVFPZFh4?= =?utf-8?B?bXF2MU8rMEdrRCtIQnV3LzdiZ0xSbzNEVW1SUUVhWGhoSEFvRWE5TElwN3I1?= =?utf-8?B?WDBjUnh5OFBWWDd4RERraHdsYWZEanF4NEdMSE1xc041akJWM3RzMThmaHBk?= =?utf-8?B?QVRsUXlodnFQRHNuOVFVWUlRVUN6M3plNUw1R0I3bTRLQndjTWtJNGFqOE1V?= =?utf-8?B?Z1hKWkMxZWYyQXRBSUVlQ1JSYkRhWGRSeS9CZlBRelkyZW0zM0xKVUZRQnNs?= =?utf-8?B?Z0hFMzFLSjFNaUVBYWh3bVZGejcxRmVKRVpxV1pXODMvZFl4ek9Xa3Nwd2lY?= =?utf-8?B?WC81Z1dCRlhQM3dVTll1SWdhTHg2dDdBTXhaSm1sV3hhYVBnVmtNemZDZDU4?= =?utf-8?B?aXI4Ky8xWlMzU1B5cGRqUEN1VjFNUVJzMjh3YzNwS3BoVEpDeEp2ZVpBd3BM?= =?utf-8?B?Ry8xdE91M3loOTRqZEZZK25tQnc0ZWU0bU9QdkFtWi9rWGI5elc0emdlVWE3?= =?utf-8?B?WERaMGp6WjdnTVhITUJwbysyOUkwWENrNTMrNFQxcEtjU3VTanp3b21QbHY4?= =?utf-8?B?Y3JCTDBtclpyYVlXSkczUFpqdE5yZHErVGJPR0UyM1p1bE00clZ0SjRYcW1M?= =?utf-8?B?V09zTmw1V0EvS2NsQlRreDkxK3lGeWtja1UwVGZHWENNR0FLTFdCeEJ3ME56?= =?utf-8?Q?qbX8w78KF4ECBCk0E0nL4tw+L?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 315e1106-e298-45d4-7caa-08daa6310e5a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 17:51:25.3265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xt6dVvghT8LNwWX0mkRa2ipqvG8Ld3AoXa/5O5G9j9JAh0lVEQmCfi0m5mQ0f7rR X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6257 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/24/2022 3:45 AM, longli@linuxonhyperv.com wrote: > > From: Long Li > > MANA is a network interface card to be used in the Azure cloud environment. > MANA provides safe access to user memory through memory registration. It has > IOMMU built into the hardware. > > MANA uses IB verbs and RDMA layer to configure hardware resources. It > requires the corresponding RDMA kernel-mode and user-mode drivers. > > The MANA RDMA kernel-mode driver is being reviewed at: > https://patchwork.kernel.org/project/netdevbpf/list/?series=678843&state=* > > The MANA RDMA user-mode driver is being reviewed at: > https://github.com/linux-rdma/rdma-core/pull/1177 > > > Long Li (18): > net/mana: add basic driver with build environment and doc > net/mana: device configuration and stop > net/mana: report supported ptypes > net/mana: support link update > net/mana: support device removal interrupts > net/mana: report device info > net/mana: configure RSS > net/mana: configure Rx queues > net/mana: configure Tx queues > net/mana: implement memory registration > net/mana: implement the hardware layer operations > net/mana: start/stop Tx queues > net/mana: start/stop Rx queues > net/mana: receive packets > net/mana: send packets > net/mana: start/stop device > net/mana: report queue stats > net/mana: support Rx interrupts > Hi Long, Driver looks good, only I put a few minor comments, can you please check them? Thanks, ferruh