* [PATCH] vhost: fix log for async dequeue
@ 2022-06-17 5:40 David Marchand
2022-06-17 14:00 ` Maxime Coquelin
2022-06-17 14:09 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: David Marchand @ 2022-06-17 5:40 UTC (permalink / raw)
To: dev; +Cc: Maxime Coquelin, Chenbo Xia, Yuan Wang, Xuan Ding
Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"),
vhost logs contain the socket path as a prefix.
Async dequeue path was copied from the sync dequeue path but a log
was incorrect.
Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/vhost/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 68a26eb17d..bedd406b37 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3529,7 +3529,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
rarp_mbuf = rte_net_make_rarp_packet(mbuf_pool, &dev->mac);
if (rarp_mbuf == NULL) {
- VHOST_LOG_DATA(ERR, "Failed to make RARP packet.\n");
+ VHOST_LOG_DATA(ERR, "(%s) failed to make RARP packet.\n", dev->ifname);
count = 0;
goto out;
}
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: fix log for async dequeue
2022-06-17 5:40 [PATCH] vhost: fix log for async dequeue David Marchand
@ 2022-06-17 14:00 ` Maxime Coquelin
2022-06-17 14:09 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-06-17 14:00 UTC (permalink / raw)
To: David Marchand, dev; +Cc: Chenbo Xia, Yuan Wang, Xuan Ding
On 6/17/22 07:40, David Marchand wrote:
> Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"),
> vhost logs contain the socket path as a prefix.
> Async dequeue path was copied from the sync dequeue path but a log
> was incorrect.
>
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 68a26eb17d..bedd406b37 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -3529,7 +3529,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
>
> rarp_mbuf = rte_net_make_rarp_packet(mbuf_pool, &dev->mac);
> if (rarp_mbuf == NULL) {
> - VHOST_LOG_DATA(ERR, "Failed to make RARP packet.\n");
> + VHOST_LOG_DATA(ERR, "(%s) failed to make RARP packet.\n", dev->ifname);
> count = 0;
> goto out;
> }
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: fix log for async dequeue
2022-06-17 5:40 [PATCH] vhost: fix log for async dequeue David Marchand
2022-06-17 14:00 ` Maxime Coquelin
@ 2022-06-17 14:09 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-06-17 14:09 UTC (permalink / raw)
To: David Marchand, dev; +Cc: Chenbo Xia, Yuan Wang, Xuan Ding
On 6/17/22 07:40, David Marchand wrote:
> Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"),
> vhost logs contain the socket path as a prefix.
> Async dequeue path was copied from the sync dequeue path but a log
> was incorrect.
>
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-17 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 5:40 [PATCH] vhost: fix log for async dequeue David Marchand
2022-06-17 14:00 ` Maxime Coquelin
2022-06-17 14:09 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).