From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2384CA0093; Fri, 17 Jun 2022 16:00:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19A86410E7; Fri, 17 Jun 2022 16:00:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C83B840F19 for ; Fri, 17 Jun 2022 16:00:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655474419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNQCYCwoGnl8tLqUcZuI609m30etEpyu04l1mnKPYLY=; b=P3xyeHG42lNNdAGQXHoWLPedAscW0YFp4pcogXphacpapqA5aalwCxtEg0g2MrYTkQMW32 JkLG6uqrP81tOydi4vcr3apqGtdBSSBzic5Pu+BFL+MCljTtMU8WohaRaiPQKe/ABwmhYm LFZWIjjt3TCprgJZER2ILNH8pn0TRQk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-O7r_kvH8NkWBbnjwl1iGhQ-1; Fri, 17 Jun 2022 10:00:16 -0400 X-MC-Unique: O7r_kvH8NkWBbnjwl1iGhQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D8CD93C0E21A; Fri, 17 Jun 2022 14:00:15 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5259B4619F1; Fri, 17 Jun 2022 14:00:14 +0000 (UTC) Message-ID: <09753bf0-3d54-0749-88a9-e80370982be2@redhat.com> Date: Fri, 17 Jun 2022 16:00:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] vhost: fix log for async dequeue To: David Marchand , dev@dpdk.org Cc: Chenbo Xia , Yuan Wang , Xuan Ding References: <20220617054003.1291251-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220617054003.1291251-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/17/22 07:40, David Marchand wrote: > Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), > vhost logs contain the socket path as a prefix. > Async dequeue path was copied from the sync dequeue path but a log > was incorrect. > > Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") > > Signed-off-by: David Marchand > --- > lib/vhost/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 68a26eb17d..bedd406b37 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -3529,7 +3529,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id, > > rarp_mbuf = rte_net_make_rarp_packet(mbuf_pool, &dev->mac); > if (rarp_mbuf == NULL) { > - VHOST_LOG_DATA(ERR, "Failed to make RARP packet.\n"); > + VHOST_LOG_DATA(ERR, "(%s) failed to make RARP packet.\n", dev->ifname); > count = 0; > goto out; > } Reviewed-by: Maxime Coquelin Thanks, Maxime