From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 069A4325F
for <dev@dpdk.org>; Mon, 26 Mar 2018 09:13:10 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
106C414005C; Mon, 26 Mar 2018 07:13:08 +0000 (UTC)
Received: from [192.168.38.17] (84.52.114.114) by ocex03.SolarFlarecom.com
(10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 26 Mar
2018 00:13:05 -0700
To: <dev@dpdk.org>
CC: Olivier MATZ <olivier.matz@6wind.com>, Hemant Agrawal
<hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>
References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com>
<1521994855-8808-1-git-send-email-arybchenko@solarflare.com>
<1521994855-8808-10-git-send-email-arybchenko@solarflare.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <097cc6d4-f6fa-9934-a48a-775ba087d5bd@solarflare.com>
Date: Mon, 26 Mar 2018 10:13:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1521994855-8808-10-git-send-email-arybchenko@solarflare.com>
Content-Language: en-GB
X-Originating-IP: [84.52.114.114]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
ocex03.SolarFlarecom.com (10.20.40.36)
X-MDID: 1522048389-gfkLLYgbXZp2
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 09/11] mempool/dpaa: prepare to remove
register memory area op
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Mar 2018 07:13:11 -0000
On 03/25/2018 07:20 PM, Andrew Rybchenko wrote:
> Populate mempool driver callback is executed a bit later than
> register memory area, provides the same information and will
> substitute the later since it gives more flexibility and in addition
> to notification about memory area allows to customize how mempool
> objects are stored in memory.
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v1 -> v2:
> - fix build error because of prototype mismatch
>
> drivers/mempool/dpaa/dpaa_mempool.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
> index 7b82f4b..0dcb488 100644
> --- a/drivers/mempool/dpaa/dpaa_mempool.c
> +++ b/drivers/mempool/dpaa/dpaa_mempool.c
> @@ -264,10 +264,9 @@ dpaa_mbuf_get_count(const struct rte_mempool *mp)
> }
>
> static int
> -dpaa_register_memory_area(const struct rte_mempool *mp,
> - char *vaddr __rte_unused,
> - rte_iova_t paddr __rte_unused,
> - size_t len)
> +dpaa_populate(struct rte_mempool *mp, unsigned int max_objs,
> + char *vaddr, rte_iova_t paddr, size_t len,
Self NACK, 'void *vaddr' must be above
> + rte_mempool_populate_obj_cb_t *obj_cb, void *obj_cb_arg)
> {
> struct dpaa_bp_info *bp_info;
> unsigned int total_elt_sz;
> @@ -289,7 +288,9 @@ dpaa_register_memory_area(const struct rte_mempool *mp,
> if (len >= total_elt_sz * mp->size)
> bp_info->flags |= DPAA_MPOOL_SINGLE_SEGMENT;
>
> - return 0;
> + return rte_mempool_op_populate_default(mp, max_objs, vaddr, paddr, len,
> + obj_cb, obj_cb_arg);
> +
> }
>
> struct rte_mempool_ops dpaa_mpool_ops = {
> @@ -299,7 +300,7 @@ struct rte_mempool_ops dpaa_mpool_ops = {
> .enqueue = dpaa_mbuf_free_bulk,
> .dequeue = dpaa_mbuf_alloc_bulk,
> .get_count = dpaa_mbuf_get_count,
> - .register_memory_area = dpaa_register_memory_area,
> + .populate = dpaa_populate,
> };
>
> MEMPOOL_REGISTER_OPS(dpaa_mpool_ops);