From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9B0922C58 for ; Mon, 9 Jan 2017 14:30:53 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP; 09 Jan 2017 05:30:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="50900511" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga005.jf.intel.com with ESMTP; 09 Jan 2017 05:30:51 -0800 To: Yong Wang , helin.zhang@intel.com, jingjing.wu@intel.com References: <1483969732-20073-1-git-send-email-wang.yong19@zte.com.cn> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <099e06c8-1fa3-3684-a36c-e4b86f5c6912@intel.com> Date: Mon, 9 Jan 2017 13:30:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483969732-20073-1-git-send-email-wang.yong19@zte.com.cn> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 13:30:54 -0000 On 1/9/2017 1:48 PM, Yong Wang wrote: > In function "reassemble_packets()", the statement "end = secondlast;" > is redundant since there is another assignment "start = end = NULL;" > 3 lines below. BTW, I removed the redundant braces in the conditional > statement "if (end->data_len > rxq->crc_len)". > > Signed-off-by: Yong Wang Acked-by: Ferruh Yigit