From: "Brandes, Shai" <shaibran@amazon.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Bernstein, Amit" <amitbern@amazon.com>
Subject: RE: [PATCH 1/1] net/ena: add histogram support
Date: Thu, 31 Oct 2024 12:46:18 +0000 [thread overview]
Message-ID: <09be14ea3d7847699bc8c7262d8b3b73@amazon.com> (raw)
In-Reply-To: <20241029092234.0935fd9a@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 29, 2024 6:23 PM
> To: Brandes, Shai <shaibran@amazon.com>
> Cc: ferruh.yigit@amd.com; dev@dpdk.org; Bernstein, Amit
> <amitbern@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH 1/1] net/ena: add histogram support
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On Tue, 29 Oct 2024 10:02:15 +0200
> <shaibran@amazon.com> wrote:
>
> > From: Shai Brandes <shaibran@amazon.com>
> >
> > The framework computes the differences between specified start and end
> > points in the code, providing insights into performance by outputting
> > a histogram of the time intervals.
> > The histogram can be used to track metrics like packet processing
> > latency in the network driver.
> > This framework requires enablement via a compilation flag and is
> > excluded in release builds by default.
> >
> > Signed-off-by: Amit Bernstein <amitbern@amazon.com>
> > Signed-off-by: Shai Brandes <shaibran@amazon.com>
>
> Could this be generic for all PMD's and built off of existing DPDK trace
> mechanism?
>
> Yes, histogram is useful.
> But IMHO DPDK should discourage PMD specific features.
[Brandes, Shai] Acknowledged, thanks for your insights!
next prev parent reply other threads:[~2024-10-31 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 8:02 [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 shaibran
2024-10-29 8:02 ` [PATCH 1/1] net/ena: add histogram support shaibran
2024-10-29 16:22 ` Stephen Hemminger
2024-10-31 12:46 ` Brandes, Shai [this message]
2024-10-29 8:54 ` [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0 Morten Brørup
2024-10-31 12:45 ` Brandes, Shai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09be14ea3d7847699bc8c7262d8b3b73@amazon.com \
--to=shaibran@amazon.com \
--cc=amitbern@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).