From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CE7445C20; Thu, 31 Oct 2024 13:46:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DAF94356E; Thu, 31 Oct 2024 13:46:24 +0100 (CET) Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by mails.dpdk.org (Postfix) with ESMTP id C5C3440264 for ; Thu, 31 Oct 2024 13:46:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1730378782; x=1761914782; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=PuTtnJC8LPE55duvIJarDOtY4kcY82nsZGRvXT2TtrU=; b=DQNadRsIUXvgFG+/4lvLQ5lE4OtTAb/qcisGd0mG3rz6a8+Dm4ICKGXF i6xMHbfcUEd7CGhFPR3lNzrvmMocALbs7plE9lA0S9r6pdxh7MmzedOs/ u/VR/Tn4+Lq2GFm6c61byzU8X6ALs2sWbOumKzFPbgdbybvM0DJCgDfC/ I=; X-IronPort-AV: E=Sophos;i="6.11,247,1725321600"; d="scan'208";a="436125152" Subject: RE: [PATCH 1/1] net/ena: add histogram support Thread-Topic: [PATCH 1/1] net/ena: add histogram support Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 12:46:20 +0000 Received: from EX19MTAEUA002.ant.amazon.com [10.0.17.79:45874] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.24.44:2525] with esmtp (Farcaster) id a504417c-2674-4ac1-ac66-46d2a8df5af7; Thu, 31 Oct 2024 12:46:19 +0000 (UTC) X-Farcaster-Flow-ID: a504417c-2674-4ac1-ac66-46d2a8df5af7 Received: from EX19D037EUC004.ant.amazon.com (10.252.61.170) by EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Thu, 31 Oct 2024 12:46:18 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D037EUC004.ant.amazon.com (10.252.61.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Thu, 31 Oct 2024 12:46:18 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.035; Thu, 31 Oct 2024 12:46:18 +0000 From: "Brandes, Shai" To: Stephen Hemminger CC: "ferruh.yigit@amd.com" , "dev@dpdk.org" , "Bernstein, Amit" Thread-Index: AQHbKdjh7jTCB6PzRkWnEi/ATEJBXLKd6dMAgALoMqA= Date: Thu, 31 Oct 2024 12:46:18 +0000 Message-ID: <09be14ea3d7847699bc8c7262d8b3b73@amazon.com> References: <20241029080215.5069-1-shaibran@amazon.com> <20241029080215.5069-2-shaibran@amazon.com> <20241029092234.0935fd9a@hermes.local> In-Reply-To: <20241029092234.0935fd9a@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.51.153] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 29, 2024 6:23 PM > To: Brandes, Shai > Cc: ferruh.yigit@amd.com; dev@dpdk.org; Bernstein, Amit > > Subject: RE: [EXTERNAL] [PATCH 1/1] net/ena: add histogram support >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you can confirm the sender and know the > content is safe. >=20 >=20 >=20 > On Tue, 29 Oct 2024 10:02:15 +0200 > wrote: >=20 > > From: Shai Brandes > > > > The framework computes the differences between specified start and end > > points in the code, providing insights into performance by outputting > > a histogram of the time intervals. > > The histogram can be used to track metrics like packet processing > > latency in the network driver. > > This framework requires enablement via a compilation flag and is > > excluded in release builds by default. > > > > Signed-off-by: Amit Bernstein > > Signed-off-by: Shai Brandes >=20 > Could this be generic for all PMD's and built off of existing DPDK trace > mechanism? >=20 > Yes, histogram is useful. > But IMHO DPDK should discourage PMD specific features. [Brandes, Shai] Acknowledged, thanks for your insights!