From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7B85A5F13 for ; Mon, 24 Sep 2018 17:54:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 08:54:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="93273992" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.55]) ([10.237.220.55]) by orsmga001.jf.intel.com with ESMTP; 24 Sep 2018 08:54:46 -0700 To: Nikolay Nikolaev , maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org References: <153780242838.17494.4512397995243433980.stgit@T460> <153780249865.17494.6292437035663379898.stgit@T460> From: "Burakov, Anatoly" Message-ID: <09c0daa0-7718-1bd2-93ce-2aa091e52466@intel.com> Date: Mon, 24 Sep 2018 16:54:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <153780249865.17494.6292437035663379898.stgit@T460> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 4/5] vhost: unify message handling function signature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 15:54:50 -0000 On 24-Sep-18 4:21 PM, Nikolay Nikolaev wrote: > Each vhost-user message handling function will return an int result > which is described in the new enum vh_result: error, OK and reply. > All functions will now have two arguments, virtio_net double pointer > and VhostUserMsg pointer. > > Signed-off-by: Nikolay Nikolaev > --- > get_blk_size(int fd) > { > @@ -127,27 +137,31 @@ vhost_backend_cleanup(struct virtio_net *dev) > * the device hasn't been initialised. > */ > static int > -vhost_user_set_owner(void) > +vhost_user_set_owner(struct virtio_net **pdev __rte_unused, > + VhostUserMsg * msg __rte_unused) Missed a few instances of using a typedef in this patch. -- Thanks, Anatoly