From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51D8B460C7; Tue, 21 Jan 2025 03:40:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC22F427B7; Tue, 21 Jan 2025 03:40:04 +0100 (CET) Received: from lf-2-34.ptr.blmpb.com (lf-2-34.ptr.blmpb.com [101.36.218.34]) by mails.dpdk.org (Postfix) with ESMTP id D8CAC427B4 for ; Tue, 21 Jan 2025 03:40:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1737427192; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=LeNqRbdGtHKRwg5QeWJjStc3el7mOQ0vcB598CrSBls=; b=LPyOPN4sNorTVxmpP+yQtqrSCnKc7/Gexsv40BZjHzaQwf99/qIKtCfu29rkl+cCSU80lU XQScEtHZxgsMcIQQ8dE4sxSyRIXja6w0zENO5zIsAtEIUNHOef5kEm1QuRbfd86S79zxYK jK/EcqDJfoRVtVaozNuxnlvhcRb5+zl7eGWG025kzSF7xb9zn9XdNBqinHyZcCDFFR6FUx 3ONk/gTDmiQ+sWl46o0SKWV0eyJdsWYZdc01a4aVs8RTNsnKsrW9I90Y8Bln5qUnYmQejn uWO3sfbJI0oAYAUwVQk+eVoI1sj4U9/CvVPS1Z+N8jQkW0xRo2l6PQCQhyoA8w== Content-Type: text/plain; charset=UTF-8 To: "Stephen Hemminger" Cc: , , , , , , , , From: "WanRenyong" Received: from [127.0.0.1] ([218.1.186.193]) by smtp.feishu.cn with ESMTPS; Tue, 21 Jan 2025 10:39:49 +0800 Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/15] net/xsc: add xsc mailbox Date: Tue, 21 Jan 2025 10:39:48 +0800 Message-Id: <09c8767d-13d2-4fe2-8481-f228d36eb151@yunsilicon.com> Mime-Version: 1.0 In-Reply-To: <20250120101838.04d8c100@hermes.local> X-Original-From: WanRenyong References: <20250120111431.1048479-1-wanry@yunsilicon.com> <20250120111436.1048479-4-wanry@yunsilicon.com> <20250120101838.04d8c100@hermes.local> X-Lms-Return-Path: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/1/21 2:18, Stephen Hemminger wrote: > On Mon, 20 Jan 2025 19:14:37 +0800 > "WanRenyong" wrote: > >> +static void >> +xsc_cmdq_mbox_free(struct xsc_dev *xdev, struct xsc_cmdq_mbox *mbox) >> +{ >> + struct xsc_cmdq_mbox *next, *head; >> + struct xsc_vfio_priv *priv = (struct xsc_vfio_priv *)xdev->dev_priv; > Since dev_priv is void *, the cast here is unnecessary in C OK, I'll fix it in the next version. Thanks for your review. -- Best regards, WanRenyong