From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95DD645713; Thu, 1 Aug 2024 14:56:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69A1040E4C; Thu, 1 Aug 2024 14:56:47 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 8C4AB40A73 for ; Thu, 1 Aug 2024 14:56:46 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D9B515A1; Thu, 1 Aug 2024 05:57:11 -0700 (PDT) Received: from [10.1.38.17] (JR4XG4HTQC.cambridge.arm.com [10.1.38.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 689E03F766; Thu, 1 Aug 2024 05:56:44 -0700 (PDT) Message-ID: <09d150ae-ab9c-4d12-a435-feab69e55fd8@arm.com> Date: Thu, 1 Aug 2024 13:56:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: dts: dynamic config test suite Content-Language: en-GB To: Dean Marx , Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, bruce.richardson@intel.com Cc: dev@dpdk.org References: <20240708190858.26583-1-dmarx@iol.unh.edu> <20240708190858.26583-4-dmarx@iol.unh.edu> From: Luca Vizzarro In-Reply-To: <20240708190858.26583-4-dmarx@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Can you please rebase this on the latest changes, as the code will look different for sure? Three comments in the meantime: * Is there a reason for sleeping for 6 seconds? If so could you please explain it? * Please follow naming standards consistently, variables should be in snake_case, referring to isPromisc -> is_promisc * Please follow contributing guidelines when writing your commit subject and body[1] o Example I can spot are capitalisation of wording and the non-imperative subject Thanks, Luca [1] https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line