From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D776A0613 for ; Fri, 30 Aug 2019 10:44:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07D8F1E8B2; Fri, 30 Aug 2019 10:44:14 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0BAF01E899 for ; Fri, 30 Aug 2019 10:44:12 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EB6618C427D; Fri, 30 Aug 2019 08:44:11 +0000 (UTC) Received: from [10.36.112.16] (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51638101E683; Fri, 30 Aug 2019 08:44:10 +0000 (UTC) To: Noa Ezra Cc: matan@mellanox.com, dev@dpdk.org References: <1560924825-220648-1-git-send-email-noae@mellanox.com> <1560924825-220648-2-git-send-email-noae@mellanox.com> From: Maxime Coquelin Openpgp: preference=signencrypt Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <09eb3767-9369-7323-a293-7d051a880bda@redhat.com> Date: Fri, 30 Aug 2019 10:44:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1560924825-220648-2-git-send-email-noae@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Fri, 30 Aug 2019 08:44:11 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/19/19 8:13 AM, Noa Ezra wrote: > TSO (TCP Segmentation Offload) is enabled by default on vhost. > Add the ability to disable TSO on vhost. > The user should also disable the feature on the virtual machine's xml. > > Signed-off-by: Noa Ezra > Reviewed-by: Matan Azrad > --- > doc/guides/nics/vhost.rst | 5 +++++ > drivers/net/vhost/rte_eth_vhost.c | 30 +++++++++++++++++++++++++++--- > 2 files changed, 32 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics/vhost.rst > index 23f2e87..8cfda4d 100644 > --- a/doc/guides/nics/vhost.rst > +++ b/doc/guides/nics/vhost.rst > @@ -76,6 +76,11 @@ The user can specify below arguments in `--vdev` option. > It is used to enable postcopy live-migration support in vhost library. > (Default: 0 (disabled)) > > +#. ``tso``: > + > + It is used to disable tso support in vhost library. > + (Default: 1 (enabled)) > + > Vhost PMD event handling > ------------------------ > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index b2cda04..a38c235 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -31,6 +31,7 @@ > #define ETH_VHOST_DEQUEUE_ZERO_COPY "dequeue-zero-copy" > #define ETH_VHOST_IOMMU_SUPPORT "iommu-support" > #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" > +#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" > #define VHOST_MAX_PKT_BURST 32 > > static const char *valid_arguments[] = { > @@ -40,6 +41,7 @@ > ETH_VHOST_DEQUEUE_ZERO_COPY, > ETH_VHOST_IOMMU_SUPPORT, > ETH_VHOST_POSTCOPY_SUPPORT, > + ETH_VHOST_VIRTIO_NET_F_HOST_TSO, > NULL > }; > > @@ -1200,7 +1202,8 @@ struct vhost_xstats_name_off { > > static int > eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, > - int16_t queues, const unsigned int numa_node, uint64_t flags) > + int16_t queues, const unsigned int numa_node, uint64_t flags, > + uint64_t disable_flags) > { > const char *name = rte_vdev_device_name(dev); > struct rte_eth_dev_data *data; > @@ -1272,6 +1275,11 @@ struct vhost_xstats_name_off { > if (rte_vhost_driver_register(iface_name, flags)) > goto error; > > + if (disable_flags) { > + if (rte_vhost_driver_disable_features(iface_name, disable_flags)) > + goto error; > + } > + > if (rte_vhost_driver_callback_register(iface_name, &vhost_ops) < 0) { > VHOST_LOG(ERR, "Can't register callbacks\n"); > goto error; > @@ -1334,10 +1342,12 @@ struct vhost_xstats_name_off { > char *iface_name; > uint16_t queues; > uint64_t flags = 0; > + uint64_t disable_flags = 0; > int client_mode = 0; > int dequeue_zero_copy = 0; > int iommu_support = 0; > int postcopy_support = 0; > + int tso = 1; > struct rte_eth_dev *eth_dev; > const char *name = rte_vdev_device_name(dev); > > @@ -1419,11 +1429,24 @@ struct vhost_xstats_name_off { > flags |= RTE_VHOST_USER_POSTCOPY_SUPPORT; > } > > + if (rte_kvargs_count(kvlist, ETH_VHOST_VIRTIO_NET_F_HOST_TSO) == 1) { > + ret = rte_kvargs_process(kvlist, > + ETH_VHOST_VIRTIO_NET_F_HOST_TSO, > + &open_int, &tso); > + if (ret < 0) > + goto out_free; > + > + if (tso == 0) { > + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); > + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); > + } > + } > + > if (dev->device.numa_node == SOCKET_ID_ANY) > dev->device.numa_node = rte_socket_id(); > > eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node, > - flags); > + flags, disable_flags); > > out_free: > rte_kvargs_free(kvlist); > @@ -1470,7 +1493,8 @@ struct vhost_xstats_name_off { > "client=<0|1> " > "dequeue-zero-copy=<0|1> " > "iommu-support=<0|1> " > - "postcopy-support=<0|1>"); > + "postcopy-support=<0|1> " > + "tso=<0|1>"); > > RTE_INIT(vhost_init_log) > { > With changing the default to disabled: Reviewed-by: Maxime Coquelin Do you want me to do the change while applying or you prefer sending the v2? Thanks, Maxime