From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>
Subject: Re: [dpdk-dev] rte_eth_dev_attach returns 0, although device is not attached
Date: Thu, 4 Aug 2016 14:51:35 +0300 [thread overview]
Message-ID: <0AB336DF-9C66-4826-BA17-EDE1F8D6A2EA@nfware.com> (raw)
In-Reply-To: <57A32814.1000404@intel.com>
Hello Ferruh,
> 4 авг. 2016 г., в 14:33, Ferruh Yigit <ferruh.yigit@intel.com> написал(а):
>
> Hi Igor,
>
> On 8/3/2016 5:58 PM, Igor Ryzhov wrote:
>> Hello.
>>
>> Function rte_eth_dev_attach can return false positive result.
>> It happens because rte_eal_pci_probe_one returns zero if no driver is found for the device:
>> ret = pci_probe_all_drivers(dev);
>> if (ret < 0)
>> goto err_return;
>> return 0;
>> (pci_probe_all_drivers returns 1 in that case)
>>
>> For example, it can be easily reproduced by trying to attach virtio device, managed by kernel driver.
>
> You are right, and I did able to reproduce this issue with virtio as you
> suggest.
>
> But I wonder why rte_eth_dev_get_port_by_addr() is not catching this.
> Perhaps a dev->attached check needs to be added into this function.
>
>>
>> I think it should be:
>> ret = pci_probe_all_drivers(dev);
>> if (ret)
>> goto err_return;
>> return 0;
>
> Your proposal looks good to me. Will you send a patch?
Patch sent.
>
>> Best regards,
>> Igor
>>
>
next prev parent reply other threads:[~2016-08-04 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:58 Igor Ryzhov
2016-08-04 11:33 ` Ferruh Yigit
2016-08-04 11:51 ` Igor Ryzhov [this message]
2016-08-04 13:21 ` Ferruh Yigit
2016-08-04 14:54 ` Igor Ryzhov
2016-08-04 15:47 ` Ferruh Yigit
2016-08-05 12:29 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0AB336DF-9C66-4826-BA17-EDE1F8D6A2EA@nfware.com \
--to=iryzhov@nfware.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).