From: "Xu, Rosen" <rosen.xu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
Date: Mon, 14 May 2018 10:06:49 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D739FDE541@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1658878.RdDdYUol4R@xps>
Hi,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, May 13, 2018 18:07
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
>
> 12/05/2018 09:02, Pablo de Lara:
> > Gcc 8 reports a build error:
> >
> > drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified bound
> > 256 equals destination size [-Werror=stringop-truncation]
> > strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
> >
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Applied, thanks
Thanks a lot Pablo.
>
prev parent reply other threads:[~2018-05-14 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 7:02 Pablo de Lara
2018-05-13 10:07 ` Thomas Monjalon
2018-05-14 10:06 ` Xu, Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D739FDE541@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).