From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <rosen.xu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 44459231E
for <dev@dpdk.org>; Tue, 22 May 2018 12:42:55 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
22 May 2018 03:42:54 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,429,1520924400"; d="scan'208";a="51228996"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by FMSMGA003.fm.intel.com with ESMTP; 22 May 2018 03:42:53 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 22 May 2018 03:42:53 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 22 May 2018 03:42:52 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.240]) by
SHSMSX151.ccr.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002;
Tue, 22 May 2018 18:42:50 +0800
From: "Xu, Rosen" <rosen.xu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "shreyansh.jain@nxp.com"
<shreyansh.jain@nxp.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Zhang, Tianfei"
<tianfei.zhang@intel.com>, "Liu, Song" <song.liu@intel.com>, "Wu, Hao"
<hao.wu@intel.com>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
Thread-Topic: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
issue
Thread-Index: AQHT7R00hG2l/CbSy0KOl15QeRetLqQ5vfqAgAHaQDA=
Date: Tue, 22 May 2018 10:42:50 +0000
Message-ID: <0E78D399C70DA940A335608C6ED296D73A00BDBD@SHSMSX104.ccr.corp.intel.com>
References: <1526478813-154172-1-git-send-email-rosen.xu@intel.com>
<1913991.jNxr5nhODZ@xps>
In-Reply-To: <1913991.jNxr5nhODZ@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDk0ZDIwMmQtZjM5My00YjQ2LWFlMDYtMGFiNjczMWRlZTZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiencxdndKT29xWFdxOWV4STN5Zm9YZWR3bkR0VHcwS09acmFCVWRFQ3plbWQrTGVjb3F1a2xxbXdOXC9MVDYwSFwvIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix
coverity issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 10:42:55 -0000
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 21, 2018 22:23
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; shreyansh.jain@nxp.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>;
> Liu, Song <song.liu@intel.com>; Wu, Hao <hao.wu@intel.com>;
> gaetan.rivet@6wind.com
> Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
> issue
>=20
> 16/05/2018 15:53, Rosen Xu:
> > Fix coverity issue: 279449
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Coverity issue: 279449
> > Cc: stable@dpdk.org
>=20
> Not for stable
>=20
> > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > @@ -227,7 +227,7 @@
> > int file_fd;
> > int ret =3D 0;
> > ssize_t buffer_size;
> > - void *buffer;
> > + void *buffer =3D NULL;
>=20
> It is not fixing anything.
> This variable cannot be read before being written.
Yes, it's a scripts error.
This patch can be cancelled.
=20