From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 58E002C5; Tue, 31 Jul 2018 14:55:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 05:55:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,427,1526367600"; d="scan'208";a="250467722" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 31 Jul 2018 05:55:34 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Jul 2018 05:55:34 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Jul 2018 05:55:34 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Tue, 31 Jul 2018 20:55:31 +0800 From: "Xu, Rosen" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "orika@mellanox.com" , "Gilmore, Walter E" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUIait0meiFAUA8UG7I0cfOaH7zKShRouAgAgRdeA= Date: Tue, 31 Jul 2018 12:55:30 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A188D9B@SHSMSX104.ccr.corp.intel.com> References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <1532255950-105866-1-git-send-email-rosen.xu@intel.com> <4562218.vGJ9EyzqYi@xps> In-Reply-To: <4562218.vGJ9EyzqYi@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTZlMDZjOTktMTA1OS00ZTgyLWExMDUtZGVjNmM1ZGEwYTYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTzk1UmVscWxsXC9neWpURXRjZE9jOHZ1QmVvXC9pZG9iMWRWOUtxcCtHOTgyVldHa08yS2dQaGNmbW9TaVdVMzM0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 12:55:37 -0000 Hi Thomas, This is my reply. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, July 27, 2018 1:42 > To: Xu, Rosen > Cc: dev@dpdk.org; Yigit, Ferruh ; > orika@mellanox.com; Gilmore, Walter E ; > Zhang, Qi Z ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add > rte_fdir_conf initialization >=20 > 22/07/2018 12:39, Rosen Xu: > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > initialization. It is a workaround solution when working with Intel > > I40e. > [...] > > + /* > > + * Initialize fdir_conf of ete_eth_conf >=20 > Typo and lack of punctuation. Fixed. > > + * it is a workaround solution when working with Intel I40e > > + * and it is not the normal way >=20 > It is not said why it is needed, > and what are we waiting to remove the workaround. Added. > > + */ > > + .fdir_conf =3D { > > + .mode =3D RTE_FDIR_MODE_PERFECT, > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > + .status =3D RTE_FDIR_REPORT_STATUS, > > + .drop_queue =3D 127, > > + }, >=20 > Please work on a v4 with better explanations. >=20