From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 54F461B1EF for ; Tue, 9 Oct 2018 02:02:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 17:02:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,358,1534834800"; d="scan'208";a="79815734" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 08 Oct 2018 17:02:21 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Oct 2018 17:02:19 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Oct 2018 17:02:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.48]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Tue, 9 Oct 2018 08:02:18 +0800 From: "Xu, Rosen" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Singh, Jasvinder" , "jerin.jacob@caviumnetworks.com" , "Yigit, Ferruh" Thread-Topic: [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters Thread-Index: AQHUNP5ztKS3jBkNbUiCh96c29B+0KUV1cEggACGkfA= Date: Tue, 9 Oct 2018 00:02:17 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A2DA3B9@SHSMSX104.ccr.corp.intel.com> References: <1534382056-98198-1-git-send-email-rosen.xu@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7D5F9F@IRSMSX107.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7D5F9F@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTk4ZGUzYmEtYjg2MS00YzkzLThiNGMtM2QxYjJjOWVjYWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWXBtcEthejBpSU9kR05vdml4dWxiVjAwWVN0TW13OW55Myt0SnR6bnk1TEVjaHBEU2dlTGg2SUp3OTFPNFwvUVoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 00:02:32 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Tuesday, October 09, 2018 0:00 > To: Xu, Rosen ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Singh, Jasvinder > ; jerin.jacob@caviumnetworks.com; Yigit, > Ferruh > Subject: RE: [PATCH] lib/librte_ethdev: expand queue threshold size of RE= D > parameters >=20 >=20 >=20 > > -----Original Message----- > > From: Xu, Rosen > > Sent: Thursday, August 16, 2018 2:14 AM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > > ; Singh, Jasvinder ; > > jerin.jacob@caviumnetworks.com; Xu, Rosen ; Yigit, > > Ferruh > > Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED > > parameters > > > > There's very commonly that more than 4G DDR memory in NIC for HQoS, > so > > right now the queue threshold size of RED needs to expand to uint64_t. > > This patch fixes it. > > > > Signed-off-by: Rosen Xu > > --- > > lib/librte_ethdev/rte_tm.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h > > index 955f02f..646ef38 100644 > > --- a/lib/librte_ethdev/rte_tm.h > > +++ b/lib/librte_ethdev/rte_tm.h > > @@ -831,10 +831,10 @@ enum rte_tm_cman_mode { > > */ > > struct rte_tm_red_params { > > /** Minimum queue threshold */ > > - uint32_t min_th; > > + uint64_t min_th; > > > > /** Maximum queue threshold */ > > - uint32_t max_th; > > + uint64_t max_th; > > > > /** Inverse of packet marking probability maximum value (maxp), i.e. > > * maxp_inv =3D 1 / maxp > > -- > > 1.8.3.1 >=20 > Acked-by: Cristian Dumitrescu >=20 > Applied to next-qos tree, thanks! Okay, thanks a lot Cristian. What means nex-qos tree? 18.11?