From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [DPDK] /driver/bus/ifpga: fix driver probe failure handler
Date: Tue, 15 Jan 2019 08:38:59 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A4BF686@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1547430043-62302-1-git-send-email-andy.pei@intel.com>
Hi Andy,
> -----Original Message-----
> From: Pei, Andy
> Sent: Monday, January 14, 2019 9:41
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] /driver/bus/ifpga: fix driver probe failure handler
>
The subject should be started with bus/ifpga.
I think the tital should be fix ifpga afu driver probe failure handler
> In the original code, when a device probe a driver, if the driver in the driver
In the original code, when a AFU device is scanned, if its driver in the driver
> list does not support this device, a error is returned.
an error will return
> After this patch, a device wil try to match driver in the driver list one by one
With this patch, a device will......
> until an appropriate driver is found. If the current driver does not support
> the device or some error happens, just try the next driver in the list.
> If all the drivers in the list are tried and no driver matches. 0 is returned.
>
> fixes: 05fa3d4a6539
Pls use git fixline 05fa3d4a6539 to generate the full fixline
> cc: rosen.xu@intel.com
> cc: tianfei.zhang@intel.com
> cc: andy.pei@intel.com
Don't need these cc, pls only Cc: stable@dpdk.org
> Signed-off-by: AndyPei <andy.pei@intel.com>
> ---
> drivers/bus/ifpga/ifpga_bus.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index e4b7b6f..55d3abf 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -306,12 +306,19 @@ void rte_ifpga_driver_unregister(struct
> rte_afu_driver *driver)
> }
>
> TAILQ_FOREACH(drv, &ifpga_afu_drv_list, next) {
> - if (ifpga_probe_one_driver(drv, afu_dev)) {
> - ret = -1;
> - break;
> - }
> + ret = ifpga_probe_one_driver(drv, afu_dev);
> + if (ret < 0)
> + /* negative value is an error */
> + return ret;
> + if (ret > 0)
> + /* positive value means driver doesn't support it */
> + continue;
> + return 0;
> }
> - return ret;
> + if ((ret > 0) && (afu_dev->driver == NULL))
> + return 0;
> + else
> + return ret;
> }
>
> /*
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-01-15 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 1:40 AndyPei
2019-01-14 5:14 ` Xu, Rosen
2019-01-15 8:38 ` Xu, Rosen [this message]
2019-01-17 5:36 ` [dpdk-dev] [DPDK] bus/ifpga: fix ifpga afu " Andy Pei
2019-01-18 11:12 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-01-18 19:06 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A4BF686@SHSMSX152.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).