From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 182972BCE; Thu, 17 Jan 2019 09:36:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 00:36:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="136519705" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 17 Jan 2019 00:36:18 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 00:36:17 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 00:36:18 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 16:36:16 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [DPDK] bus/ifpga: fix a brackets unmatch Thread-Index: AQHUriZC2uJsGxU88UmDykbkuII0q6WzIe+A Date: Thu, 17 Jan 2019 08:36:15 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A4CCE36@SHSMSX152.ccr.corp.intel.com> References: <1547445668-15578-1-git-send-email-andy.pei@intel.com> <1547703135-195893-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1547703135-195893-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmFiZWVkYzgtZDgwOC00MjY5LWFlNjAtZTI4MGFlZTU1NmM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnpGZGNpdjY3cGk5SjVYQ1hkSW5NQ2tXdjdWS2EwUVwvYWlkV3FLZVpWNFBjd2J1Y3dCeWpBaDMxRk1SdlwvRXZDIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] bus/ifpga: fix a brackets unmatch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 08:36:19 -0000 Hi, > -----Original Message----- > From: Pei, Andy > Sent: Thursday, January 17, 2019 13:32 > To: dev@dpdk.org > Cc: Xu, Rosen ; Pei, Andy ; > stable@dpdk.org > Subject: [DPDK] bus/ifpga: fix a brackets unmatch I think it's v2 patch, so pls identify it. For the title, I think this one could be better. C linkage names declaration brackets mismatch > The code >=20 > extern "C" { >=20 > miss a related >=20 > } Pls descript it in detail not in demo code. >=20 > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h > b/drivers/bus/ifpga/rte_bus_ifpga.h > index d53c0f4..0bf43ba 100644 > --- a/drivers/bus/ifpga/rte_bus_ifpga.h > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h > @@ -13,7 +13,7 @@ >=20 > #ifdef __cplusplus > extern "C" { > -#endif > +#endif /* __cplusplus */ >=20 > #include > #include > @@ -143,4 +143,8 @@ struct rte_afu_driver { #define > RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\ static const char *afudrvinit_ ## > nm ## _alias =3D RTE_STR(alias) >=20 > +#ifdef __cplusplus > +} > +#endif /* __cplusplus */ > + > #endif /* _RTE_BUS_IFPGA_H_ */ > -- > 1.8.3.1