DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ipn3ke: check input arguement before other operation
@ 2019-05-22  7:21 Andy Pei
  2019-05-23  2:30 ` Xu, Rosen
  2019-05-23  2:53 ` [dpdk-dev] [PATCH v2] net/ipn3ke: check input argument " Andy Pei
  0 siblings, 2 replies; 6+ messages in thread
From: Andy Pei @ 2019-05-22  7:21 UTC (permalink / raw)
  To: dev; +Cc: andy.pei, rosen.xu, stable

check input arguement rte_eth_dev *ethdev, ensuring ethdev
is not NULl before operation on ethdev.

Coverity issue: 337922
Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
Cc: rosen.xu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/net/ipn3ke/ipn3ke_representor.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index cf3b214..32d4fc8 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -735,13 +735,16 @@
 	enum rte_filter_type filter_type, enum rte_filter_op filter_op,
 	void *arg)
 {
-	struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(ethdev);
-	struct ipn3ke_rpst *rpst = IPN3KE_DEV_PRIVATE_TO_RPST(ethdev);
 	int ret = 0;
+	struct ipn3ke_hw *hw = NULL;
+	struct ipn3ke_rpst *rpst = NULL;
 
 	if (ethdev == NULL)
 		return -EINVAL;
 
+	hw = IPN3KE_DEV_PRIVATE_TO_HW(ethdev);
+	rpst = IPN3KE_DEV_PRIVATE_TO_RPST(ethdev);
+
 	if (hw->acc_flow)
 		switch (filter_type) {
 		case RTE_ETH_FILTER_GENERIC:
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-18 13:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22  7:21 [dpdk-dev] [PATCH] net/ipn3ke: check input arguement before other operation Andy Pei
2019-05-23  2:30 ` Xu, Rosen
2019-05-23  3:05   ` Pei, Andy
2019-05-23  2:53 ` [dpdk-dev] [PATCH v2] net/ipn3ke: check input argument " Andy Pei
2019-05-23  2:59   ` Xu, Rosen
2019-06-18 13:31     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).