From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Zhang, Tianfei" <tianfei.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] raw/ifpga: fix logically dead code
Date: Mon, 10 Jun 2019 07:27:45 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A7DA667@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190604155149.23955-2-tianfei.zhang@intel.com>
Hi,
> -----Original Message-----
> From: Zhang, Tianfei
> Sent: Tuesday, June 04, 2019 23:52
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Cc: Zhang, Tianfei <tianfei.zhang@intel.com>; stable@dpdk.org; Zhang
> Subject: [PATCH v2 2/2] raw/ifpga: fix logically dead code
Pls use ./devtools/check-git-log.sh to check git log before send patch.
> add temporary variable in max10_reg_write().
>
> Coverity issue: 337927
> Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>
> ---
> drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
> b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
> index f354ee4b6..3ff6575d7 100644
> --- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
> +++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c
> @@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int
> *val)
>
> int max10_reg_write(unsigned int reg, unsigned int val) {
> + unsigned int tmp = val;
> +
> if (!g_max10)
> return -ENODEV;
>
> return spi_transaction_write(g_max10->spi_tran_dev,
> - reg, 4, (unsigned char *)&val);
> + reg, 4, (unsigned char *)&tmp);
> }
>
> struct intel_max10_device *
> @@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device
> *spi,
>
> /* set PKVL Polling manually in BBS */
> ret = max10_reg_write(PKVL_POLLING_CTRL, 0x3);
> - if (ret) {
> + if (ret != 0) {
> dev_err(dev, "%s set PKVL polling fail\n", __func__);
> goto spi_tran_fail;
> }
> --
> 2.17.1
next prev parent reply other threads:[~2019-06-10 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 15:51 [dpdk-dev] [PATCH v2 1/2] raw/ifpga: fix use of untrusted scalar value Zhang, Tianfei
2019-06-04 15:51 ` [dpdk-dev] [PATCH v2 2/2] raw/ifpga: fix logically dead code Zhang, Tianfei
2019-06-10 7:27 ` Xu, Rosen [this message]
2019-06-10 7:27 ` [dpdk-dev] [PATCH v2 1/2] raw/ifpga: fix use of untrusted scalar value Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A7DA667@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).