From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 847FEA0487 for ; Tue, 2 Jul 2019 12:00:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B32425F11; Tue, 2 Jul 2019 12:00:19 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2CEA15B34 for ; Tue, 2 Jul 2019 12:00:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 03:00:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,442,1557212400"; d="scan'208";a="165615399" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 02 Jul 2019 03:00:17 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 03:00:17 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 2 Jul 2019 03:00:16 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 2 Jul 2019 03:00:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0439.000; Tue, 2 Jul 2019 18:00:15 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" , "Yigit, Ferruh" , "Zhang, Tianfei" Thread-Topic: [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask Thread-Index: AQHVL/n1m1oQ8Hmn80aUgr7rxsKo0qa3Gd7A Date: Tue, 2 Jul 2019 10:00:14 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A863A18@SHSMSX104.ccr.corp.intel.com> References: <1561449612-26372-4-git-send-email-andy.pei@intel.com> <1561977388-51692-1-git-send-email-andy.pei@intel.com> <1561977388-51692-2-git-send-email-andy.pei@intel.com> In-Reply-To: <1561977388-51692-2-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTU2Y2M4NzgtOTRjOS00ZWQwLTllMmMtZDU3OTgxZWI2ODZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicmswaWRjU2lPc1kzaXYyZEtwempxYU1Db0oxYmduNXlHVnB3UFJTXC8wdGVLZlNtMlNWeXdmT1Rhek4zYnNNTG4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pei, Andy > Sent: Monday, July 01, 2019 18:36 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen > Subject: [PATCH v5 2/4] net/ipn3ke: delete MAC register address mask >=20 > original code is compatible with older device, whose mac register address= is > no more than 10 bits. Now we have mac register address longer than 10 bit= s, > so we just delete the mask here. >=20 > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Cc: rosen.xu@intel.com >=20 > Signed-off-by: Andy Pei > --- > drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c > b/drivers/net/ipn3ke/ipn3ke_ethdev.c > index 9079b57..8d3084d 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c > @@ -48,7 +48,6 @@ > if (eth_group_sel !=3D 0 && eth_group_sel !=3D 1) > return -1; >=20 > - addr &=3D 0x3FF; > target_addr =3D addr | dev_sel << 17; >=20 > indirect_value =3D RCMD | target_addr << 32; @@ -86,7 +85,6 @@ > if (eth_group_sel !=3D 0 && eth_group_sel !=3D 1) > return -1; >=20 > - addr &=3D 0x3FF; > target_addr =3D addr | dev_sel << 17; >=20 > indirect_value =3D WCMD | target_addr << 32 | wr_data; > -- > 1.8.3.1 Acked-by: Rosen Xu