From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 336F6A10DA for ; Wed, 31 Jul 2019 09:29:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A3661C0AE; Wed, 31 Jul 2019 09:29:51 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 461461C07E for ; Wed, 31 Jul 2019 09:29:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 00:29:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,329,1559545200"; d="scan'208";a="183593119" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 31 Jul 2019 00:29:47 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 00:29:47 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 00:29:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 15:29:46 +0800 From: "Xu, Rosen" To: Thomas Monjalon , "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , Nipun Gupta , "Zhang, Tianfei" , "Richardson, Bruce" , "Li, Xiaoyun" , "Wu, Jingjing" , Satha Rao , "Vamsi Attunuru" , Shreyansh Jain , Hemant Agrawal CC: Neil Horman Thread-Topic: [PATCH v2 2/2] drivers/raw: standardize naming Thread-Index: AQHVRtxdOa59FgM7VEuoDuP17Af6UKbkVWlQ Date: Wed, 31 Jul 2019 07:29:45 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A905BDD@SHSMSX104.ccr.corp.intel.com> References: <20190705093401.69913-1-bruce.richardson@intel.com> <20190730133937.22540-1-thomas@monjalon.net> <20190730133937.22540-3-thomas@monjalon.net> In-Reply-To: <20190730133937.22540-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWM0ZjdjYTktYzdkYy00MjA2LThkYTktMjhmNjhlNjBlOGQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaTVtRnQzMHJSRHNmdUlIV2s5bkdyd0k1ZldtaldlTndpNm1cL2pDUlVNRjJYVFdNYjZYNmhhdUpMcG1jNmt4dDUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/raw: standardize naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I'm okay if it's applied in 19.11. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 30, 2019 21:40 > To: dev@dpdk.org; Mcnamara, John ; > Kovacevic, Marko ; Nipun Gupta > ; Xu, Rosen ; Zhang, Tianfei > ; Richardson, Bruce > ; Li, Xiaoyun ; Wu, > Jingjing ; Satha Rao ; > Vamsi Attunuru ; Shreyansh Jain > ; Hemant Agrawal > Cc: Neil Horman > Subject: [PATCH v2 2/2] drivers/raw: standardize naming >=20 > From: Bruce Richardson >=20 > The driver names for rawdevs were both different in make and meson builds > and were non-standard in the make version in that some included "rawdev" > in the name while others didn't. >=20 > Therefore, for global consistency of naming, we can use "rte_rawdev" rath= er > than "rte_pmd" for the prefix for the libraries. While most other driver > categories use "rte_pmd" as a prefix, there is precedent for this in the > mempool drivers use "rte_mempool" as a prefix. >=20 > Signed-off-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/release_19_08.rst | 3 +++ > drivers/raw/dpaa2_cmdif/Makefile | 4 ++-- > ...sion.map =3D> rte_rawdev_dpaa2_cmdif_version.map} | 0 > drivers/raw/dpaa2_qdma/Makefile | 4 ++-- > ...rsion.map =3D> rte_rawdev_dpaa2_qdma_version.map} | 0 > drivers/raw/ifpga/Makefile | 4 ++-- > ...ga_version.map =3D> rte_rawdev_ifpga_version.map} | 0 > drivers/raw/ioat/Makefile | 4 ++-- > ...oat_version.map =3D> rte_rawdev_ioat_version.map} | 0 > drivers/raw/meson.build | 2 +- > drivers/raw/ntb/Makefile | 4 ++-- > ..._ntb_version.map =3D> rte_rawdev_ntb_version.map} | 0 > drivers/raw/octeontx2_dma/Makefile | 4 ++-- > ...on.map =3D> rte_rawdev_octeontx2_dma_version.map} | 0 > drivers/raw/skeleton/Makefile | 4 ++-- > ...version.map =3D> rte_rawdev_skeleton_version.map} | 0 > mk/rte.app.mk | 14 +++++++------- > 17 files changed, 25 insertions(+), 22 deletions(-) rename > drivers/raw/dpaa2_cmdif/{rte_pmd_dpaa2_cmdif_version.map =3D> > rte_rawdev_dpaa2_cmdif_version.map} (100%) rename > drivers/raw/dpaa2_qdma/{rte_pmd_dpaa2_qdma_version.map =3D> > rte_rawdev_dpaa2_qdma_version.map} (100%) rename > drivers/raw/ifpga/{rte_pmd_ifpga_version.map =3D> > rte_rawdev_ifpga_version.map} (100%) rename > drivers/raw/ioat/{rte_pmd_ioat_version.map =3D> > rte_rawdev_ioat_version.map} (100%) rename > drivers/raw/ntb/{rte_pmd_ntb_version.map =3D> > rte_rawdev_ntb_version.map} (100%) rename > drivers/raw/octeontx2_dma/{rte_pmd_octeontx2_dma_version.map =3D> > rte_rawdev_octeontx2_dma_version.map} (100%) rename > drivers/raw/skeleton/{rte_pmd_skeleton_version.map =3D> > rte_rawdev_skeleton_version.map} (100%) >=20 > diff --git a/doc/guides/rel_notes/release_19_08.rst > b/doc/guides/rel_notes/release_19_08.rst > index fcd1386a5..13a98f520 100644 > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -351,6 +351,9 @@ ABI Changes > * bbdev: New operations and parameters added to support new 5GNR > operations. > The bbdev ABI is still kept experimental. >=20 > +* rawdev: The driver names have been changed to ``librte_rawdev_*``. > + Now they all have the same prefix, and same name with make and meson > builds. > + >=20 > Shared Library Versions > ----------------------- > diff --git a/drivers/raw/dpaa2_cmdif/Makefile > b/drivers/raw/dpaa2_cmdif/Makefile > index 9bd5ff229..2b4150c2d 100644 > --- a/drivers/raw/dpaa2_cmdif/Makefile > +++ b/drivers/raw/dpaa2_cmdif/Makefile > @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # # library name # - > LIB =3D librte_pmd_dpaa2_cmdif.a > +LIB =3D librte_rawdev_dpaa2_cmdif.a >=20 > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > @@ -23,7 +23,7 @@ LDLIBS +=3D -lrte_mempool_dpaa2 LDLIBS +=3D - > lrte_rawdev LDLIBS +=3D -lrte_common_dpaax >=20 > -EXPORT_MAP :=3D rte_pmd_dpaa2_cmdif_version.map > +EXPORT_MAP :=3D rte_rawdev_dpaa2_cmdif_version.map >=20 > LIBABIVER :=3D 2 >=20 > diff --git a/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map > b/drivers/raw/dpaa2_cmdif/rte_rawdev_dpaa2_cmdif_version.map > similarity index 100% > rename from drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map > rename to drivers/raw/dpaa2_cmdif/rte_rawdev_dpaa2_cmdif_version.map > diff --git a/drivers/raw/dpaa2_qdma/Makefile > b/drivers/raw/dpaa2_qdma/Makefile index f9a810cc6..0009fd4c6 100644 > --- a/drivers/raw/dpaa2_qdma/Makefile > +++ b/drivers/raw/dpaa2_qdma/Makefile > @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # # library name # - > LIB =3D librte_pmd_dpaa2_qdma.a > +LIB =3D librte_rawdev_dpaa2_qdma.a >=20 > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > @@ -24,7 +24,7 @@ LDLIBS +=3D -lrte_kvargs LDLIBS +=3D -lrte_ring LDLIB= S +=3D - > lrte_common_dpaax >=20 > -EXPORT_MAP :=3D rte_pmd_dpaa2_qdma_version.map > +EXPORT_MAP :=3D rte_rawdev_dpaa2_qdma_version.map >=20 > LIBABIVER :=3D 3 >=20 > diff --git a/drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map > b/drivers/raw/dpaa2_qdma/rte_rawdev_dpaa2_qdma_version.map > similarity index 100% > rename from > drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map > rename to > drivers/raw/dpaa2_qdma/rte_rawdev_dpaa2_qdma_version.map > diff --git a/drivers/raw/ifpga/Makefile b/drivers/raw/ifpga/Makefile inde= x > 5fa9303d5..655b29288 100644 > --- a/drivers/raw/ifpga/Makefile > +++ b/drivers/raw/ifpga/Makefile > @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # # library name # - > LIB =3D librte_pmd_ifpga_rawdev.a > +LIB =3D librte_rawdev_ifpga.a >=20 > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > @@ -21,7 +21,7 @@ LDLIBS +=3D -lrte_kvargs LDLIBS +=3D -lrte_bus_pci LD= LIBS > +=3D -lrte_bus_ifpga >=20 > -EXPORT_MAP :=3D rte_pmd_ifpga_version.map > +EXPORT_MAP :=3D rte_rawdev_ifpga_version.map >=20 > LIBABIVER :=3D 1 >=20 > diff --git a/drivers/raw/ifpga/rte_pmd_ifpga_version.map > b/drivers/raw/ifpga/rte_rawdev_ifpga_version.map > similarity index 100% > rename from drivers/raw/ifpga/rte_pmd_ifpga_version.map > rename to drivers/raw/ifpga/rte_rawdev_ifpga_version.map > diff --git a/drivers/raw/ioat/Makefile b/drivers/raw/ioat/Makefile index > 32f079845..e852afb57 100644 > --- a/drivers/raw/ioat/Makefile > +++ b/drivers/raw/ioat/Makefile > @@ -4,7 +4,7 @@ > include $(RTE_SDK)/mk/rte.vars.mk >=20 > # library name > -LIB =3D librte_pmd_ioat_rawdev.a > +LIB =3D librte_rawdev_ioat.a >=20 > # build flags > CFLAGS +=3D -O3 > @@ -18,7 +18,7 @@ LDLIBS +=3D -lrte_mbuf -lrte_mempool LIBABIVER :=3D 1 >=20 > # versioning export map > -EXPORT_MAP :=3D rte_pmd_ioat_version.map > +EXPORT_MAP :=3D rte_rawdev_ioat_version.map >=20 > # library source files > SRCS-$(CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV) +=3D ioat_rawdev.c diff -- > git a/drivers/raw/ioat/rte_pmd_ioat_version.map > b/drivers/raw/ioat/rte_rawdev_ioat_version.map > similarity index 100% > rename from drivers/raw/ioat/rte_pmd_ioat_version.map > rename to drivers/raw/ioat/rte_rawdev_ioat_version.map > diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index > bcd5553e1..d7037cd87 100644 > --- a/drivers/raw/meson.build > +++ b/drivers/raw/meson.build > @@ -7,4 +7,4 @@ drivers =3D ['dpaa2_cmdif', 'dpaa2_qdma', > 'skeleton'] > std_deps =3D ['rawdev'] > config_flag_fmt =3D 'RTE_LIBRTE_PMD_@0@_RAWDEV' > -driver_name_fmt =3D 'rte_pmd_@0@' > +driver_name_fmt =3D 'rte_rawdev_@0@' > diff --git a/drivers/raw/ntb/Makefile b/drivers/raw/ntb/Makefile index > edd49fe75..6fe2aaf40 100644 > --- a/drivers/raw/ntb/Makefile > +++ b/drivers/raw/ntb/Makefile > @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # # library name # - > LIB =3D librte_pmd_ntb.a > +LIB =3D librte_rawdev_ntb.a >=20 > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > @@ -15,7 +15,7 @@ LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool LDLIBS > +=3D -lrte_pci -lrte_bus_pci LDLIBS +=3D -lrte_rawdev >=20 > -EXPORT_MAP :=3D rte_pmd_ntb_version.map > +EXPORT_MAP :=3D rte_rawdev_ntb_version.map >=20 > LIBABIVER :=3D 1 >=20 > diff --git a/drivers/raw/ntb/rte_pmd_ntb_version.map > b/drivers/raw/ntb/rte_rawdev_ntb_version.map > similarity index 100% > rename from drivers/raw/ntb/rte_pmd_ntb_version.map > rename to drivers/raw/ntb/rte_rawdev_ntb_version.map > diff --git a/drivers/raw/octeontx2_dma/Makefile > b/drivers/raw/octeontx2_dma/Makefile > index 96f782eb6..f101e4916 100644 > --- a/drivers/raw/octeontx2_dma/Makefile > +++ b/drivers/raw/octeontx2_dma/Makefile > @@ -5,7 +5,7 @@ > include $(RTE_SDK)/mk/rte.vars.mk >=20 > # library name > -LIB =3D librte_pmd_octeontx2_dma.a > +LIB =3D librte_rawdev_octeontx2_dma.a >=20 > CFLAGS +=3D -O3 $(WERROR_FLAGS) > CFLAGS +=3D -I$(RTE_SDK)/drivers/common/octeontx2/ > @@ -22,7 +22,7 @@ CFLAGS +=3D -diag-disable 2259 endif endif >=20 > -EXPORT_MAP :=3D rte_pmd_octeontx2_dma_version.map > +EXPORT_MAP :=3D rte_rawdev_octeontx2_dma_version.map >=20 > LIBABIVER :=3D 1 >=20 > diff --git > a/drivers/raw/octeontx2_dma/rte_pmd_octeontx2_dma_version.map > b/drivers/raw/octeontx2_dma/rte_rawdev_octeontx2_dma_version.map > similarity index 100% > rename from > drivers/raw/octeontx2_dma/rte_pmd_octeontx2_dma_version.map > rename to > drivers/raw/octeontx2_dma/rte_rawdev_octeontx2_dma_version.map > diff --git a/drivers/raw/skeleton/Makefile b/drivers/raw/skeleton/Makefil= e > index 9641e6505..783b1e952 100644 > --- a/drivers/raw/skeleton/Makefile > +++ b/drivers/raw/skeleton/Makefile > @@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk # # library name # - > LIB =3D librte_pmd_skeleton_rawdev.a > +LIB =3D librte_rawdev_skeleton.a >=20 > CFLAGS +=3D -O3 > CFLAGS +=3D $(WERROR_FLAGS) > @@ -15,7 +15,7 @@ LDLIBS +=3D -lrte_rawdev LDLIBS +=3D -lrte_bus_vdev > LDLIBS +=3D -lrte_kvargs >=20 > -EXPORT_MAP :=3D rte_pmd_skeleton_version.map > +EXPORT_MAP :=3D rte_rawdev_skeleton_version.map >=20 > LIBABIVER :=3D 1 >=20 > diff --git a/drivers/raw/skeleton/rte_pmd_skeleton_version.map > b/drivers/raw/skeleton/rte_rawdev_skeleton_version.map > similarity index 100% > rename from drivers/raw/skeleton/rte_pmd_skeleton_version.map > rename to drivers/raw/skeleton/rte_rawdev_skeleton_version.map > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index a277c808e..ba5c39e01 > 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -312,19 +312,19 @@ _LDLIBS- > $(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) +=3D -lrte_pmd_opdl_event > endif # CONFIG_RTE_LIBRTE_EVENTDEV >=20 > ifeq ($(CONFIG_RTE_LIBRTE_RAWDEV),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=3D - > lrte_pmd_skeleton_rawdev > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) +=3D > +-lrte_rawdev_skeleton > ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) +=3D - > lrte_pmd_dpaa2_cmdif > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) +=3D - > lrte_pmd_dpaa2_qdma > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) +=3D > +-lrte_rawdev_dpaa2_cmdif > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) +=3D > +-lrte_rawdev_dpaa2_qdma > endif # CONFIG_RTE_LIBRTE_FSLMC_BUS > _LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) +=3D -lrte_bus_ifpga > ifeq ($(CONFIG_RTE_LIBRTE_IFPGA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV) +=3D - > lrte_pmd_ifpga_rawdev > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV) +=3D - > lrte_rawdev_ifpga > _LDLIBS-$(CONFIG_RTE_LIBRTE_IPN3KE_PMD) +=3D -lrte_pmd_ipn3ke > endif # CONFIG_RTE_LIBRTE_IFPGA_BUS > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV) +=3D - > lrte_pmd_ioat_rawdev > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV) +=3D -lrte_pmd_ntb > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV) +=3D - > lrte_pmd_octeontx2_dma > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV) +=3D - > lrte_rawdev_ioat > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV) +=3D -lrte_rawdev_ntb > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_DMA_RAWDEV) +=3D > +-lrte_rawdev_octeontx2_dma > endif # CONFIG_RTE_LIBRTE_RAWDEV >=20 > endif # !CONFIG_RTE_BUILD_SHARED_LIBS > -- > 2.21.0 Acked-by: Rosen Xu