From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15F53A32A2 for ; Fri, 25 Oct 2019 03:17:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 532251E8AA; Fri, 25 Oct 2019 03:17:03 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 08A241E8A4 for ; Fri, 25 Oct 2019 03:17:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 18:16:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,226,1569308400"; d="scan'208";a="210273085" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2019 18:16:58 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 24 Oct 2019 18:16:59 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 24 Oct 2019 18:16:58 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX151.ccr.corp.intel.com ([10.239.6.50]) with mapi id 14.03.0439.000; Fri, 25 Oct 2019 09:16:57 +0800 From: "Xu, Rosen" To: "Richardson, Bruce" , "Pei, Andy" CC: "dev@dpdk.org" , "Zhang, Tianfei" , "Ye, Xiaolong" , "Zhang, Qi Z" , "Yigit, Ferruh" Thread-Topic: [PATCH v13 05/19] raw/ifpga/base: add device tree support Thread-Index: AQHVimGCidHHRkOE00u/w7AmPUxH+qdpPagAgAFQ6qA= Date: Fri, 25 Oct 2019 01:16:56 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AAE00D6@SHSMSX104.ccr.corp.intel.com> References: <1571826408-151532-2-git-send-email-andy.pei@intel.com> <1571917119-149534-1-git-send-email-andy.pei@intel.com> <1571917119-149534-6-git-send-email-andy.pei@intel.com> <20191024130928.GA1747@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191024130928.GA1747@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU5MDA3ZGYtNmRhMS00ZjExLThkNGQtM2IzYTliNTkwOTU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUWkzalVsV3ZnVE9NY1FlV3Vhd0VheFNJSlhcLzRteXcxb3hWV1wvcHVFZm5LcVlTVTRmdG5yWUtueGZyQlFwbkJJIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v13 05/19] raw/ifpga/base: add device tree support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Thursday, October 24, 2019 21:09 > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Ye, Xiaolong ; Zhang, Q= i > Z ; Yigit, Ferruh > Subject: Re: [PATCH v13 05/19] raw/ifpga/base: add device tree support >=20 > On Thu, Oct 24, 2019 at 07:38:25PM +0800, Andy Pei wrote: > > From: Tianfei zhang > > > > In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage > > the board configuration, like sensors, flash controller, QSFP, powers. > > And this is a SPI bus connected between A10 FPGA and MAX10, we can > > access the MAX10 registers over this SPI bus. > > > > In BMC, there are about 19 sensors in MAX10 chip, including the FPGA > > core temperature, Board temperature, board current, voltage and so on. > > > > We use DTB (Device tree table) to describe it. This DTB file is store > > in nor flash partition, which will flashed in Factory when the boards > > delivery to customers. And the same time, the customers can easy to > > customizate the BMC configuration like change the sensors. > > > > Add device tree support by using libfdt library in Linux distribution. > > The end-user should pre-install the libfdt and libfdt-devel package > > before use DPDK on PAC N3000 Card. > > > > For Centos 7.x: sudo yum install libfdt libfdt-devel For Ubuntu 18.04: > > sudo apt install libfdt-dev libfdt1 > > > > To eliminate build error, we currently do not compile raw/ifpga and > > net/ipn3ke. User should install libfdt and libfdt-devel first, modify > > config/common_linux, CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dn > > to CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dy, modify > config/common_base, > > CONFIG_RTE_LIBRTE_IPN3KE_PMD=3Dn to > CONFIG_RTE_LIBRTE_IPN3KE_PMD=3Dy. > > Then this function can work. > > > > Signed-off-by: Tianfei zhang > > Signed-off-by: Andy Pei > > --- > > config/common_base | 2 +- > > config/common_linux | 2 +- > > drivers/meson.build | 6 +- > > drivers/net/ipn3ke/meson.build | 24 +++- > > drivers/raw/ifpga/base/meson.build | 2 +- > > drivers/raw/ifpga/base/opae_intel_max10.c | 183 > > ++++++++++++++++++++++++++++++ > drivers/raw/ifpga/base/opae_intel_max10.h | 10 ++ > > drivers/raw/ifpga/meson.build | 25 ++-- > > mk/rte.app.mk | 2 +- > > 9 files changed, 235 insertions(+), 21 deletions(-) > > > > diff --git a/config/common_base b/config/common_base index > > fef2f38..3c0ea7e 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -339,7 +339,7 @@ CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=3Dn > > # > > # Compile burst-oriented IPN3KE PMD driver # > > -CONFIG_RTE_LIBRTE_IPN3KE_PMD=3Dy > > +CONFIG_RTE_LIBRTE_IPN3KE_PMD=3Dn > > > > # > > # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD diff --git > > a/config/common_linux b/config/common_linux index a78b8c6..c5cf3d6 > > 100644 > > --- a/config/common_linux > > +++ b/config/common_linux > > @@ -73,4 +73,4 @@ CONFIG_RTE_LIBRTE_HNS3_PMD=3Dy # Compile PMD > for > > Intel FPGA raw device # To compile, CONFIG_RTE_EAL_VFIO should be > > enabled. > > # > > -CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dy > > +CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dn > > diff --git a/drivers/meson.build b/drivers/meson.build index > > 4a1cb8b..7c0aed1 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -9,12 +9,12 @@ endif > > dpdk_driver_classes =3D ['common', > > 'bus', > > 'mempool', # depends on common and bus. > > - 'net', # depends on common, bus and mempool. > > + 'raw', # depends on common and bus. > > + 'net', # depends on common, bus, mempool and raw (raw > provide API for net driver). >=20 > The comment in brackets is unnecessary here, since that is what is implie= d by > saying that there is a dependency on net. Thinking about it more, I think= it > would be useful in future to make this more concrete for debugging, and > specify what drivers in one set depend on elements in another [assuming i= t's > only one or two]. It's not as though all net drivers depend on the rawdev= s. Okay, will remove it. > > 'crypto', # depends on common, bus and mempool (net in > future). > > 'compress', # depends on common, bus, mempool. > > 'event', # depends on common, bus, mempool and net. > > - 'baseband', # depends on common and bus. > > - 'raw'] # depends on common, bus, mempool, net and event. >=20 > I assume that the comment here is incorrect, and that no rawdev does > depend on event drivers or net drivers? Have you checked each driver for > such a dependency? Yes, we have checked it. And build it. > > + 'baseband'] # depends on common and bus. > > > > disabled_drivers =3D get_option('disable_drivers').split(',') > > >=20 > Assuming that the comment is incorrect, and that no existing rawdev drive= r > depends on a net or event driver, no issues with this meson change. >=20 > Acked-by: Bruce Richardson Thanks a lot.