From: "Xu, Rosen" <rosen.xu@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Kevin Traynor <ktraynor@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 5/9] net/ipn3ke: remove useless if statement
Date: Fri, 8 Nov 2019 14:35:30 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73AB3917E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8xU1yCwyy6eV56YwywPG1fND3s3-kYKTnycDPZ2gGvQVA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Wednesday, October 30, 2019 16:01
> To: Kevin Traynor <ktraynor@redhat.com>
> Cc: dev <dev@dpdk.org>; Xu, Rosen <rosen.xu@intel.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: [dpdk-stable] [PATCH 5/9] net/ipn3ke: remove useless if
> statement
>
> On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> >
> > Coverity complains that this statement is not needed as the goto label
> > is on the next line anyway. Remove the if statement.
> >
> > 653 ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
> > CID 337930 (#1 of 1): Identical code for different branches
> > (IDENTICAL_BRANCHES)identical_branches: The same code is executed
> > when the condition ret is true or false, because the code in the
> > if-then branch and after the if statement is identical. Should
> > the if statement be removed?
> > 654 if (ret)
> > 655 goto end;
> > implicit_else: The code from the above if-then branch is identical
> > to the code after the if statement.
> > 656end:
> >
> > Coverity issue: 337930
> > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> > Cc: rosen.xu@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> > drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > b/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > index c226d6313..282295f49 100644
> > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
> > @@ -652,6 +652,5 @@ ipn3ke_cfg_probe(struct rte_vdev_device *dev)
> >
> > ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
> > - if (ret)
> > - goto end;
> > +
> > end:
> > if (kvlist)
> > --
> > 2.21.0
> >
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
> --
> David Marchand
Reviewed-by: Rosen Xu <rosen.xu@intel.com>
next prev parent reply other threads:[~2019-11-08 14:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:53 [dpdk-dev] [PATCH 0/9] Coverity fixes and other cleanups Kevin Traynor
2019-10-01 12:53 ` [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks Kevin Traynor
2019-10-04 10:57 ` Ferriter, Cian
2019-10-30 7:52 ` David Marchand
2019-11-05 16:40 ` Kevin Traynor
2019-11-05 17:10 ` Ferriter, Cian
2019-11-06 19:03 ` Kevin Traynor
2019-10-01 13:03 ` [dpdk-dev] [PATCH 2/9] crypto/octeontx: fix possible NULL deference Kevin Traynor
2019-10-01 13:03 ` [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code Kevin Traynor
2019-10-02 1:28 ` Ajit Khaparde
2019-10-30 7:43 ` David Marchand
2019-10-30 16:27 ` Ajit Khaparde
2019-11-05 15:39 ` Kevin Traynor
2019-10-01 13:04 ` [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic Kevin Traynor
2019-10-30 7:59 ` David Marchand
2019-11-05 15:41 ` Kevin Traynor
2019-11-08 14:45 ` Xu, Rosen
2019-11-08 14:47 ` Kevin Traynor
2019-11-08 14:35 ` Xu, Rosen
2019-11-08 14:52 ` Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 5/9] net/ipn3ke: remove useless if statement Kevin Traynor
2019-10-30 8:01 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-08 14:35 ` Xu, Rosen [this message]
2019-11-08 14:52 ` [dpdk-dev] " Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 6/9] net/ipn3ke: remove commented out code Kevin Traynor
2019-10-30 8:04 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-08 14:40 ` Xu, Rosen
2019-11-08 14:51 ` [dpdk-dev] " Xu, Rosen
2019-10-01 13:04 ` [dpdk-dev] [PATCH 7/9] compress/octeontx: " Kevin Traynor
2019-10-30 8:06 ` David Marchand
2019-10-01 13:04 ` [dpdk-dev] [PATCH 8/9] event/opdl: " Kevin Traynor
2019-10-03 10:50 ` Liang, Ma
2019-10-01 13:04 ` [dpdk-dev] [PATCH 9/9] net/bnxt: " Kevin Traynor
2019-10-01 15:42 ` Ajit Khaparde
2019-10-30 7:56 ` [dpdk-dev] [dpdk-stable] [PATCH 2/9] crypto/octeontx: fix possible NULL deference David Marchand
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 1/8] net/pcap: fix argument checks Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 2/8] common/cpt: fix possible NULL deference Kevin Traynor
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 3/8] net/ipn3ke: fix incorrect commit check logic Kevin Traynor
2019-11-08 14:50 ` Xu, Rosen
2019-11-06 19:01 ` [dpdk-dev] [v2 PATCH 4/8] net/ipn3ke: remove useless if statement Kevin Traynor
2019-11-08 14:49 ` Xu, Rosen
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 5/8] net/ipn3ke: remove commented out code Kevin Traynor
2019-11-08 14:50 ` Xu, Rosen
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 6/8] compress/octeontx: " Kevin Traynor
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 7/8] event/opdl: " Kevin Traynor
2019-11-06 19:02 ` [dpdk-dev] [v2 PATCH 8/8] net/bnxt: " Kevin Traynor
2019-11-08 14:07 ` [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups David Marchand
2019-11-08 14:41 ` Xu, Rosen
2019-11-08 15:15 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73AB3917E@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).