From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61AEDA04C7; Thu, 21 Nov 2019 06:32:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38AD02BA3; Thu, 21 Nov 2019 06:32:26 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C5A212BA2 for ; Thu, 21 Nov 2019 06:32:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 21:32:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="205046686" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 20 Nov 2019 21:32:23 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 21:32:23 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 21:32:23 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 13:32:21 +0800 From: "Xu, Rosen" To: Thomas Monjalon CC: "dev@dpdk.org" , "Zhang, Tianfei" , "Pei, Andy" , "Ye, Xiaolong" , "Yigit, Ferruh" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler Thread-Index: AQHVmsqWXaW9dSbNNk2JRtsfH4imQaeUFbsAgAEOmcA= Date: Thu, 21 Nov 2019 05:32:20 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AB7D00C@SHSMSX104.ccr.corp.intel.com> References: <1571917119-149534-2-git-send-email-andy.pei@intel.com> <1573722187-148846-1-git-send-email-rosen.xu@intel.com> <1573722187-148846-11-git-send-email-rosen.xu@intel.com> <10496132.hlKR8GaRvu@xps> In-Reply-To: <10496132.hlKR8GaRvu@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmNkYWVlZGItZGMxZi00NjgzLWI1OGEtMmJkNmFmNTAzMmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV0liSHh5d2FcL1FOa25tQnZFOHJxcllhbEN2T1YwWnQ0Ymo2b1lEb0x0U2FieWh3T3IrZUNoa2RMOXVnUjdBOFQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, November 21, 2019 5:23 > To: Xu, Rosen > Cc: dev@dpdk.org; Zhang, Tianfei ; Pei, Andy > ; Ye, Xiaolong ; Yigit, Ferruh > ; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handle= r >=20 > Rosen (and most of your colleagues), > Please use --in-reply-to when sending a new version. > All versions must be a reply to the very first cover letter. Got, thanks your reminder. > 14/11/2019 10:02, Rosen Xu: > > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val); >=20 > Using %lx is usually wrong. > val is 64-bit. > On 32-bit machines (like some Intel ones), it does not compile. > I had to fix it while pulling next-net. >=20 > The same issue was in "raw/ifpga/base: clean fme errors". >=20 > Please check 32-bit compilation. >=20 > Note: we should have such check in the CI. >=20