From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE289A04FA; Wed, 8 Jan 2020 13:39:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A9B41D6BD; Wed, 8 Jan 2020 13:39:36 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 40A0D1D6B6 for ; Wed, 8 Jan 2020 13:39:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 04:39:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,409,1571727600"; d="scan'208";a="233588973" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 08 Jan 2020 04:39:32 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 04:39:32 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 04:39:32 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Wed, 8 Jan 2020 20:39:30 +0800 From: "Xu, Rosen" To: Matan Azrad , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" CC: "Yigit, Ferruh" , "dev@dpdk.org" , Thomas Monjalon , "Pei, Andy" Thread-Topic: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Thread-Index: AQHVuza+DlyHibZbkUWWXKAfhQXAuafe6UfQgAFsDgD//8+lAIAApPrQ Date: Wed, 8 Jan 2020 12:39:29 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AC794C5@SHSMSX104.ccr.corp.intel.com> References: <1577287161-10321-1-git-send-email-matan@mellanox.com> <0E78D399C70DA940A335608C6ED296D73AC77B3E@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTQxOTVkOWItYzRhOS00MTUxLTk2YmYtZjNmYjM1Mjg5ZGRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXlmNEp2TFh6dG1ZdWpSU3JhS1hoZmthMHQzNWhGZE5qQVYwQnJFZUx6OFFTeTNZa0Y5c1N2ejhhekgxSDhOeCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, > -----Original Message----- > From: Matan Azrad > Sent: Wednesday, January 08, 2020 18:46 > To: Xu, Rosen ; Maxime Coquelin > ; Bie, Tiwei ; Wang, > Zhihong ; Wang, Xiao W > > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas Monjalon > ; Pei, Andy > Subject: RE: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA devic= e > drivers >=20 > Hi Xu >=20 > From: Xu, Rosen > > Hi Matan, > > > > Did you think about OVS DPDK? > > vDPA is a basic module for OVS, currently it will take some exception > > path packet processing for OVS, so it still needs to integrate eth_dev. >=20 > I don't understand your question. >=20 > What do you mean by "integrate eth_dev"? My questions is in OVS DPDK scenario vDPA device implements eth_dev ops, so create a new class and move ifc code to this new class is not ok. > > Thanks, > > Rosen > > > > > -----Original Message----- > > > From: dev On Behalf Of Matan Azrad > > > Sent: Tuesday, January 07, 2020 15:57 > > > To: Matan Azrad ; Maxime Coquelin > > > ; Bie, Tiwei ; > > > Wang, Zhihong ; Wang, Xiao W > > > > > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas > > > Monjalon > > > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA > > > device drivers > > > > > > Hi all > > > > > > Any comments? > > > > > > From: Matan Azrad > > > > As discussed and as described in RFC "[RFC] net: new vdpa PMD for > > > > Mellanox devices", new vDPA driver is going to be added for > > > > Mellanox devices - vDPA > > > > mlx5 and more. > > > > > > > > The only vDPA driver now is the IFC driver that is located in net > directory. > > > > > > > > The IFC driver and the new vDPA mlx5 driver provide the vDPA ops > > > > introduced in librte_vhost and not the eth-dev ops. > > > > All the others drivers in net class provide the eth-dev ops. > > > > The set of features is also different. > > > > > > > > Create a new class for vDPA drivers and move IFC to this class. > > > > Later, all the new drivers that implement the vDPA ops will be > > > > added to the vDPA class. > > > > > > > > Also, a vDPA device driver features list was added to vDPA > > documentation. > > > > > > > > Please review the features list and the series. > > > > > > > > Later on, I'm going to send the vDPA mlx5 driver. > > > > > > > > Thanks. > > > > > > > > > > > > Matan Azrad (3): > > > > drivers: introduce vDPA class > > > > doc: add vDPA feature table > > > > drivers: move ifc driver to the vDPA class > > > > > > > > MAINTAINERS | 6 +- > > > > doc/guides/conf.py | 5 + > > > > doc/guides/index.rst | 1 + > > > > doc/guides/nics/features/ifcvf.ini | 8 - > > > > doc/guides/nics/ifc.rst | 106 --- > > > > doc/guides/nics/index.rst | 1 - > > > > doc/guides/vdpadevs/features/default.ini | 55 ++ > > > > doc/guides/vdpadevs/features/ifcvf.ini | 8 + > > > > doc/guides/vdpadevs/features_overview.rst | 65 ++ > > > > doc/guides/vdpadevs/ifc.rst | 106 +++ > > > > doc/guides/vdpadevs/index.rst | 15 + > > > > drivers/Makefile | 2 + > > > > drivers/meson.build | 1 + > > > > drivers/net/Makefile | 3 - > > > > drivers/net/ifc/Makefile | 34 - > > > > drivers/net/ifc/base/ifcvf.c | 329 -------- > > > > drivers/net/ifc/base/ifcvf.h | 162 ---- > > > > drivers/net/ifc/base/ifcvf_osdep.h | 52 -- > > > > drivers/net/ifc/ifcvf_vdpa.c | 1280 -----------------= ------------ > > > > drivers/net/ifc/meson.build | 9 - > > > > drivers/net/ifc/rte_pmd_ifc_version.map | 3 - > > > > drivers/net/meson.build | 1 - > > > > drivers/vdpa/Makefile | 14 + > > > > drivers/vdpa/ifc/Makefile | 34 + > > > > drivers/vdpa/ifc/base/ifcvf.c | 329 ++++++++ > > > > drivers/vdpa/ifc/base/ifcvf.h | 162 ++++ > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 52 ++ > > > > drivers/vdpa/ifc/ifcvf_vdpa.c | 1280 > > > > +++++++++++++++++++++++++++++ > > > > drivers/vdpa/ifc/meson.build | 9 + > > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map | 3 + > > > > drivers/vdpa/meson.build | 8 + > > > > 31 files changed, 2152 insertions(+), 1991 deletions(-) delete > > > > mode > > > > 100644 doc/guides/nics/features/ifcvf.ini > > > > delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 > > > > doc/guides/vdpadevs/features/default.ini > > > > create mode 100644 doc/guides/vdpadevs/features/ifcvf.ini > > > > create mode 100644 doc/guides/vdpadevs/features_overview.rst > > > > create mode 100644 doc/guides/vdpadevs/ifc.rst create mode > > > > 100644 doc/guides/vdpadevs/index.rst delete mode 100644 > > > > drivers/net/ifc/Makefile delete mode 100644 > > > > drivers/net/ifc/base/ifcvf.c delete mode 100644 > > > > drivers/net/ifc/base/ifcvf.h delete mode 100644 > > > > drivers/net/ifc/base/ifcvf_osdep.h > > > > delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode > > > > 100644 drivers/net/ifc/meson.build delete mode 100644 > > > > drivers/net/ifc/rte_pmd_ifc_version.map > > > > create mode 100644 drivers/vdpa/Makefile create mode 100644 > > > > drivers/vdpa/ifc/Makefile create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf.c create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf.h create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h > > > > create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode > > > > 100644 drivers/vdpa/ifc/meson.build create mode 100644 > > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map > > > > create mode 100644 drivers/vdpa/meson.build > > > > > > > > -- > > > > 1.8.3.1