From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E9F5A046B; Thu, 9 Jan 2020 11:53:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E6E51DC33; Thu, 9 Jan 2020 11:53:37 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 591491DC2F for ; Thu, 9 Jan 2020 11:53:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 02:53:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="216266116" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 09 Jan 2020 02:53:35 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 02:53:34 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 02:53:34 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.132]) with mapi id 14.03.0439.000; Thu, 9 Jan 2020 18:53:32 +0800 From: "Xu, Rosen" To: Thomas Monjalon CC: Matan Azrad , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , "Pei, Andy" Thread-Topic: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Thread-Index: AQHVxiNyDwxDyyJixUGx6fiR8bhkS6fhlTjQ///pjICAAJ2eoA== Date: Thu, 9 Jan 2020 10:53:32 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AC8000B@SHSMSX104.ccr.corp.intel.com> References: <1577287161-10321-1-git-send-email-matan@mellanox.com> <2962572.5fSG56mABF@xps> <0E78D399C70DA940A335608C6ED296D73AC7E548@SHSMSX104.ccr.corp.intel.com> <1669723.3VsfAaAtOV@xps> In-Reply-To: <1669723.3VsfAaAtOV@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2E4YTg5MzYtNGViNS00Mjc2LWIxMzYtOWExMzkxMTE3YmUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVGNtOW4xTWJYXC9QdWcycEx5S1hMN0dHUnBnWHRwZTcyVEpjV3V3UTZhUWdKVGhsaWZDczV4TSsrMXVtMEptOFYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, January 09, 2020 16:41 > To: Xu, Rosen > Cc: Matan Azrad ; Maxime Coquelin > ; Bie, Tiwei ; Wang, > Zhihong ; Wang, Xiao W > ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA devic= e > drivers >=20 > 09/01/2020 03:27, Xu, Rosen: > > Hi, > > > > From: Thomas Monjalon > > > 08/01/2020 13:39, Xu, Rosen: > > > > From: Matan Azrad > > > > > From: Xu, Rosen > > > > > > Did you think about OVS DPDK? > > > > > > vDPA is a basic module for OVS, currently it will take some > > > > > > exception path packet processing for OVS, so it still needs to > > > > > > integrate > > > eth_dev. > > > > > > > > > > I don't understand your question. > > > > > > > > > > What do you mean by "integrate eth_dev"? > > > > > > > > My questions is in OVS DPDK scenario vDPA device implements > > > > eth_dev ops, so create a new class and move ifc code to this new cl= ass > is not ok. > > > > > > 1/ I don't understand the relation with OVS. > > > > > > 2/ no, vDPA device implements vDPA ops. > > > If it implements ethdev ops, it is an ethdev device. > > > > > > Please show an example of what you claim. > > > > Answers of 1 and 2. > > > > In OVS DPDK, each network device(such as NIC, vHost etc) of DPDK needs > > to be implemented as rte_eth_dev and provides eth_dev_ops such as > packet TX/RX for OVS. >=20 > No, OVS is also using the vhost API for vhost port. Yes, vhost pmd is not a good example. > > Take vHost(Virtio back end) for example, OVS startups vHost interface l= ike > this: > > ovs-vsctl add-port br0 vhost-user-1 -- set Interface vhost-user-1 > > type=3Ddpdkvhostuser drivers/net/vhost implements vHost as rte_eth_dev > and integrated in OVS. > > OVS can send/receive packets to/from VM with rte_eth_tx_burst() > > rte_eth_rx_burst() which call eth_dev_ops implementation of > drivers/net/vhost. > > No, it is using rte_vhost_dequeue_burst() and rte_vhost_enqueue_burst() > which are not in ethdev. > > > vDPA is also Virtio back end and works like vHost, same as vHost, it > > will be implemented as rte_eth_dev and also be integrated into OVS. >=20 > No, vDPA is not "implemented as rte_eth_dev". Currently, vDPA isn't integrated with OVS. =20 > > So, it's not ok to move ifc code from drivers/net. >=20 > drivers/net/ifc has no ethdev implementation at all. For OVS hasn't integrated vDPA, it doesn't implement rte_eth_dev, but there are many discussions in OVS community about vDPA, some are from Mellanox, it seems vDPA port will be implemented as rte_eth_dev port in OVS in the near feature. https://patchwork.ozlabs.org/patch/1178474/ Matan, Could you clarify how OVS integrates vDPA in Mellanox patch? >=20 > Rosen, I'm sorry, these arguments look irrelevant, so I won't consider th= em > as blocking the integration of this patch. What I mentioned is not blocking the integration of this patch, I just want= to get clarification from Matan how to integrate vDPA port in OVS.