From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88D5FA04F9; Fri, 10 Jan 2020 15:19:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24C631EA86; Fri, 10 Jan 2020 15:19:12 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5A60C1EA7A for ; Fri, 10 Jan 2020 15:19:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 06:18:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="247042785" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2020 06:18:49 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 06:18:49 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 06:18:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.28]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 22:18:47 +0800 From: "Xu, Rosen" To: Thomas Monjalon , Matan Azrad CC: Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , "Pei, Andy" , "Roni Bar Yanai" Thread-Topic: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Thread-Index: AQHVxiNyDwxDyyJixUGx6fiR8bhkS6fhlTjQ///pjICAAJ2eoP//krqAgAGBAED//+wQAAAamMbg Date: Fri, 10 Jan 2020 14:18:47 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AC890D1@SHSMSX104.ccr.corp.intel.com> References: <1577287161-10321-1-git-send-email-matan@mellanox.com> <0E78D399C70DA940A335608C6ED296D73AC869EE@SHSMSX104.ccr.corp.intel.com> <6026430.K2JlShyGXD@xps> In-Reply-To: <6026430.K2JlShyGXD@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhhZjI3YzMtYTA1OC00N2I1LTgyMTctMDExMDFlOTBjODk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWdmK2lcL3lCTjV4eWhINFJtWWZVY0hIdDMzaFwvdjhoaVZCNWVoTEE4NFBVQnRWZ0EwaFdIQ1FQXC9ET3cxZ2pVRyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 17:21 > To: Matan Azrad ; Xu, Rosen > Cc: Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong ; Wang, > Xiao W ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy ; Roni Bar Yanai > > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA devic= e > drivers >=20 > 10/01/2020 03:38, Xu, Rosen: > > From: Matan Azrad > > > From: Xu, Rosen > > > > From: Thomas Monjalon > > > > > 09/01/2020 03:27, Xu, Rosen: > > > > > > From: Thomas Monjalon > > > > > > > 08/01/2020 13:39, Xu, Rosen: > > > > > > > > From: Matan Azrad > > > > > > > > > From: Xu, Rosen > > > > > > > > > > Did you think about OVS DPDK? > > > > > > > > > > vDPA is a basic module for OVS, currently it will take > > > > > > > > > > some exception path packet processing for OVS, so it > > > > > > > > > > still needs to integrate > > > > > > > eth_dev. > > > > > > > > > > > > > > > > > > I don't understand your question. > > > > > > > > > > > > > > > > > > What do you mean by "integrate eth_dev"? > > > > > > > > > > > > > > > > My questions is in OVS DPDK scenario vDPA device > > > > > > > > implements eth_dev ops, so create a new class and move ifc > > > > > > > > code to this new class > > > > > is not ok. > > > > > > > > > > > > > > 1/ I don't understand the relation with OVS. > > > > > > > > > > > > > > 2/ no, vDPA device implements vDPA ops. > > > > > > > If it implements ethdev ops, it is an ethdev device. > > > > > > > > > > > > > > Please show an example of what you claim. > > > > > > > > > > > > Answers of 1 and 2. > > > > > > > > > > > > In OVS DPDK, each network device(such as NIC, vHost etc) of > > > > > > DPDK needs to be implemented as rte_eth_dev and provides > > > > > > eth_dev_ops > > > > such > > > > > > as > > > > > packet TX/RX for OVS. > > > > > > > > > > No, OVS is also using the vhost API for vhost port. > > > > > > > > Yes, vhost pmd is not a good example. > > > > > > > > > > Take vHost(Virtio back end) for example, OVS startups vHost > > > > > > interface like > > > > > this: > > > > > > ovs-vsctl add-port br0 vhost-user-1 -- set Interface > > > > > > vhost-user-1 type=3Ddpdkvhostuser drivers/net/vhost implements > > > > > > vHost as > > > > rte_eth_dev > > > > > and integrated in OVS. > > > > > > OVS can send/receive packets to/from VM with > > > > > > rte_eth_tx_burst() > > > > > > rte_eth_rx_burst() which call eth_dev_ops implementation of > > > > > drivers/net/vhost. > > > > > > > > > > No, it is using rte_vhost_dequeue_burst() and > > > > > rte_vhost_enqueue_burst() which are not in ethdev. > > > > > > > > > > > vDPA is also Virtio back end and works like vHost, same as > > > > > > vHost, it will be implemented as rte_eth_dev and also be integr= ated > into OVS. > > > > > > > > > > No, vDPA is not "implemented as rte_eth_dev". > > > > > > > > Currently, vDPA isn't integrated with OVS. > > > > > > > > > > So, it's not ok to move ifc code from drivers/net. > > > > > > > > > > drivers/net/ifc has no ethdev implementation at all. > > > > > > > > For OVS hasn't integrated vDPA, it doesn't implement rte_eth_dev, > > > > but there are many discussions in OVS community about vDPA, some > > > > are from Mellanox, it seems vDPA port will be implemented as > > > > rte_eth_dev port in OVS in the near feature. > > > > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= F > > > > patc > > > > h > > > > > > > > work.ozlabs.org%2Fpatch%2F1178474%2F&data=3D02%7C01%7Cmatan% > > > 4 > > > > > > > > 0mellanox.com%7C9e84c2581e2f414e0aca08d794f22e8d%7Ca652971c7d2e4 > > > d > > > > > > > 9ba6a4d149256f461b%7C0%7C0%7C637141640216181763&sdata=3DTA% > > > 2F > > > > > 0zU495kXUqhC6eP09NDzBZfjJz1dbfkRcDpV%2BYAs%3D&reserved=3D0 > > > > > > > > Matan, > > > > Could you clarify how OVS integrates vDPA in Mellanox patch? > > > > > > > > > > > > > > Rosen, I'm sorry, these arguments look irrelevant, so I won't > > > > > consider them as blocking the integration of this patch. > > > > > > > > What I mentioned is not blocking the integration of this patch, I > > > > just want to get clarification from Matan how to integrate vDPA por= t in > OVS. > > > > > > > > > Hi > > > > > > OVS like any other application should use the current API of vDPA to > > > attach a probed vdpa device to a vhost device. > > > See example application /examples/vdpa. > > > > > > Here, we just introduce a new class to hold all the vDPA drivers, no > > > change in the API. > > > > > > As I understand, no vDPA device is currently integrated in OVS. > > > > > > I think it can be integrated only when a full offload will be > > > integrated since the vDPA device forward the traffic from the HW > > > directly to the virtio queue, once it will be there, I guess the > > > offload will be configured by the representor of the vdpa device(VF) > which is managed by an ethdev device. > > > > > > > > > Matan. > > > > > Hi, > > > > I'm still confused about your last sentence " the representor of the vd= pa > device(VF) which is managed by an ethdev device". > > My understanding is that there are some connections and dependency > between rte_eth_dev and vdpa device? > > Am I right or any other explanations from you? >=20 > A vDPA port does not allow any ethdev operations (like rte_flow). > In order to configure some offloads on the device, OVS needs an ethdev po= rt. > In Mellanox case, an ethdev VF representor port can be instantiated. > So we may have two ports for the same device: > - vDPA for data path with the VM > - ethdev for offloads control path It's obviously that OVS needs these two functions of same device. In DPDK part, I have some concerns about how to scan, probe and bond these = two ports of same device. Could you introduce it? As far as I know, each network device provided by DPDK is identified as a p= ort in OVS, do you mind to take more clarification about how to connect or bond these t= wo functions of same device in OVS part?