* [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
@ 2020-03-16 20:47 David Christensen
2020-03-16 23:14 ` dwilder
2020-03-17 13:21 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: David Christensen @ 2020-03-16 20:47 UTC (permalink / raw)
To: rosen.xu, grive; +Cc: dev, David Christensen, bruce.richardson
The include file rte_debug.h is pulled into x86 builds through the
following callchain:
lib/librte_eal/common/include/generic/rte_cycles.h:17,
lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
The PPC specific version of the same callchain does not include
rte_debug.h. Add rte_debug.h back into the C files that require it.
Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
Cc: bruce.richardson@intel.com
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
drivers/bus/ifpga/ifpga_bus.c | 1 +
lib/librte_pci/rte_pci.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index dfd6b1fba..addbc3e86 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -24,6 +24,7 @@
#include <rte_kvargs.h>
#include <rte_alarm.h>
#include <rte_string_fns.h>
+#include <rte_debug.h>
#include "rte_rawdev.h"
#include "rte_rawdev_pmd.h"
diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
index a753cf3ec..d1ab6b414 100644
--- a/lib/librte_pci/rte_pci.c
+++ b/lib/librte_pci/rte_pci.c
@@ -20,6 +20,7 @@
#include <rte_eal.h>
#include <rte_string_fns.h>
#include <rte_common.h>
+#include <rte_debug.h>
#include "rte_pci.h"
--
2.18.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
2020-03-16 20:47 [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds David Christensen
@ 2020-03-16 23:14 ` dwilder
2020-03-17 13:21 ` David Marchand
1 sibling, 0 replies; 5+ messages in thread
From: dwilder @ 2020-03-16 23:14 UTC (permalink / raw)
To: David Christensen; +Cc: rosen.xu, grive, dev, bruce.richardson, drc
On 2020-03-16 13:47, David Christensen wrote:
> The include file rte_debug.h is pulled into x86 builds through the
> following callchain:
>
> lib/librte_eal/common/include/generic/rte_cycles.h:17,
> lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
> lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
> lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
>
> The PPC specific version of the same callchain does not include
> rte_debug.h. Add rte_debug.h back into the C files that require it.
>
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header
> file")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
...
Ran ci against this patch (with my ppc64le ci patches included), it ran
clean. Results are here:
https://travis-ci.org/github/djlwilder/dpdk/builds/663247710
Tested-by: David Wilder <dwilder@us.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
2020-03-16 20:47 [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds David Christensen
2020-03-16 23:14 ` dwilder
@ 2020-03-17 13:21 ` David Marchand
2020-03-17 19:39 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-03-17 13:21 UTC (permalink / raw)
To: David Christensen; +Cc: Rosen Xu, Gaetan Rivet, dev, Bruce Richardson
On Mon, Mar 16, 2020 at 9:48 PM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> The include file rte_debug.h is pulled into x86 builds through the
> following callchain:
>
> lib/librte_eal/common/include/generic/rte_cycles.h:17,
> lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
> lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
> lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
>
> The PPC specific version of the same callchain does not include
> rte_debug.h. Add rte_debug.h back into the C files that require it.
>
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
Cc: stable@dpdk.org
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
2020-03-17 13:21 ` David Marchand
@ 2020-03-17 19:39 ` David Marchand
2020-03-19 1:26 ` Xu, Rosen
0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-03-17 19:39 UTC (permalink / raw)
To: David Christensen
Cc: Rosen Xu, Gaetan Rivet, dev, Bruce Richardson, David Wilder
On Tue, Mar 17, 2020 at 2:21 PM David Marchand
<david.marchand@redhat.com> wrote:
> On Mon, Mar 16, 2020 at 9:48 PM David Christensen
> <drc@linux.vnet.ibm.com> wrote:
> >
> > The include file rte_debug.h is pulled into x86 builds through the
> > following callchain:
> >
> > lib/librte_eal/common/include/generic/rte_cycles.h:17,
> > lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
> > lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
> > lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
> >
> > The PPC specific version of the same callchain does not include
> > rte_debug.h. Add rte_debug.h back into the C files that require it.
> >
> > Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
> Cc: stable@dpdk.org
>
> >
> > Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Tested-by: David Wilder <dwilder@us.ibm.com>
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds
2020-03-17 19:39 ` David Marchand
@ 2020-03-19 1:26 ` Xu, Rosen
0 siblings, 0 replies; 5+ messages in thread
From: Xu, Rosen @ 2020-03-19 1:26 UTC (permalink / raw)
To: David Marchand, David Christensen
Cc: Gaetan Rivet, dev, Richardson, Bruce, David Wilder
Thanks David.
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 18, 2020 3:39
> To: David Christensen <drc@linux.vnet.ibm.com>
> Cc: Xu, Rosen <rosen.xu@intel.com>; Gaetan Rivet <grive@u256.net>; dev
> <dev@dpdk.org>; Richardson, Bruce <bruce.richardson@intel.com>; David
> Wilder <dwilder@us.ibm.com>
> Subject: Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power
> builds
>
> On Tue, Mar 17, 2020 at 2:21 PM David Marchand
> <david.marchand@redhat.com> wrote:
> > On Mon, Mar 16, 2020 at 9:48 PM David Christensen
> > <drc@linux.vnet.ibm.com> wrote:
> > >
> > > The include file rte_debug.h is pulled into x86 builds through the
> > > following callchain:
> > >
> > > lib/librte_eal/common/include/generic/rte_cycles.h:17,
> > > lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
> > > lib/librte_eal/common/include/arch/x86/rte_spinlock.h:18,
> > > lib/librte_eal/common/include/arch/x86/rte_rwlock.h:13,
> > >
> > > The PPC specific version of the same callchain does not include
> > > rte_debug.h. Add rte_debug.h back into the C files that require it.
> > >
> > > Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header
> > > file")
> > Cc: stable@dpdk.org
> >
> > >
> > > Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> > Tested-by: David Wilder <dwilder@us.ibm.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
>
> Applied, thanks.
>
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-19 1:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 20:47 [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds David Christensen
2020-03-16 23:14 ` dwilder
2020-03-17 13:21 ` David Marchand
2020-03-17 19:39 ` David Marchand
2020-03-19 1:26 ` Xu, Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).