From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54B10A0583; Thu, 19 Mar 2020 06:52:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A419D1AFF; Thu, 19 Mar 2020 06:52:14 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 05F9BF94; Thu, 19 Mar 2020 06:52:12 +0100 (CET) IronPort-SDR: RaRijr2qS4w0OUXrA/JVbKi66Sw862nXRbvGJWIBr+v+BFgm3XHOZPm365uQF0mSHop0ytFYEp As0CaHAXbvqg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 22:52:11 -0700 IronPort-SDR: YL8eKZRBpFt2L+RdetXs9zUazI3ISKYlhVr7/qn2esw8cWDF8EPEdooed1Fxn0HYYGVS5fH/42 3XqhCKScQwyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,570,1574150400"; d="scan'208";a="444444456" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 18 Mar 2020 22:52:11 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 22:52:10 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 22:52:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by shsmsx102.ccr.corp.intel.com ([169.254.2.50]) with mapi id 14.03.0439.000; Thu, 19 Mar 2020 13:52:08 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" , "david.marchand@redhat.com" , "Ye, Xiaolong" , "Yigit, Ferruh" , David Marchand Thread-Topic: [PATCH] net/ipn3ke: use ctrl thread to check link status Thread-Index: AQHV+1ujACx/h7R+gkuo6/k+LKbQg6hPbh0g Date: Thu, 19 Mar 2020 05:52:08 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73AE4A423@SHSMSX104.ccr.corp.intel.com> References: <1584338837-436345-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1584338837-436345-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDNiYmVmYjEtZTIxYi00YzJmLWExNmYtNGY2NzMxYTc5YjgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmVTQzRPNWZwNkRtUTFLMklIYisxUWM1XC93OHByTjlzRXZNYno4bEZTK0Fwd0I5TjFzOVNlTE9sbVg1SWhKVTQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Pei, Andy > Sent: Monday, March 16, 2020 14:07 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen ; > stable@dpdk.org; david.marchand@redhat.com; Ye, Xiaolong > ; Yigit, Ferruh > Subject: [PATCH] net/ipn3ke: use ctrl thread to check link status >=20 > ipn3ke driver creates a thread to check link status. >=20 > before this patch, pthread_create() is used to create thread, leaving the= new > thread unrestrained wrt cpu affinity. >=20 > After this patch, rte_ctrl_thread_create() is used to create thread. The > affinity of the new thread is based on the CPU affinity retrieved at the = time > rte_eal_init() was called, the dataplane and service lcores are then excl= uded. >=20 > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > Cc: david.marchand@redhat.com > Cc: xiaolong.ye@intel.com > Cc: ferruh.yigit@intel.com >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index 80122e3..b673c49 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -2598,7 +2598,8 @@ struct rte_eth_xstat_name *xstats_names, > int ret; >=20 > if (ipn3ke_rpst_scan_num =3D=3D 1) { > - ret =3D pthread_create(&ipn3ke_rpst_scan_thread, > + ret =3D rte_ctrl_thread_create(&ipn3ke_rpst_scan_thread, > + "ipn3ke scanner", > NULL, > ipn3ke_rpst_scan_handle_request, NULL); > if (ret) { > -- > 1.8.3.1 Reviewed-by: Rosen Xu