Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status

["Xu, Rosen" <rosen.xu@intel.com>]

Thanks.

> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye@intel.com>
> Sent: Thursday, March 19, 2020 21:43
> To: Pei, Andy <andy.pei@intel.com>
> Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; stable@dpdk.org;
> david.marchand@redhat.com; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] net/ipn3ke: use ctrl thread to check link status
> 
> On 03/16, Andy Pei wrote:
> >ipn3ke driver creates a thread to check link status.
> >
> >before this patch, pthread_create() is used to create thread, leaving
> >the new thread unrestrained wrt cpu affinity.
> >
> >After this patch, rte_ctrl_thread_create() is used to create thread.
> >The affinity of the new thread is based on the CPU affinity retrieved
> >at the time rte_eal_init() was called, the dataplane and service lcores
> >are then excluded.
> >
> >Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
> >Cc: rosen.xu@intel.com
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Andy Pei <andy.pei@intel.com>
> >---
> >Cc: david.marchand@redhat.com
> >Cc: xiaolong.ye@intel.com
> >Cc: ferruh.yigit@intel.com
> >
> >diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> >b/drivers/net/ipn3ke/ipn3ke_representor.c
> >index 80122e3..b673c49 100644
> >--- a/drivers/net/ipn3ke/ipn3ke_representor.c
> >+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> >@@ -2598,7 +2598,8 @@ struct rte_eth_xstat_name *xstats_names,
> > 	int ret;
> >
> > 	if (ipn3ke_rpst_scan_num == 1) {
> >-		ret = pthread_create(&ipn3ke_rpst_scan_thread,
> >+		ret = rte_ctrl_thread_create(&ipn3ke_rpst_scan_thread,
> >+			"ipn3ke scanner",
> > 			NULL,
> > 			ipn3ke_rpst_scan_handle_request, NULL);
> > 		if (ret) {
> >--
> >1.8.3.1
> >
> 
> Applied to dpdk-next-net-intel, Thanks.