From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 1FAD45949 for ; Thu, 12 Mar 2015 13:24:37 +0100 (CET) Received: by wiwl15 with SMTP id l15so47197141wiw.4 for ; Thu, 12 Mar 2015 05:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding:thread-index :content-language; bh=TCGoIPKVfXt3fBmqbDO5PeBIPPpZU04yU7hFplknm4g=; b=xoLuRLDrRbaZtvtai1fwvx5N03oi2+XcJjbxizHuKAJCkQMFK/ob26iHsjjnZyOm/Z xwSMbWYbvpAt0GGtd+z61ZEjfsGe8UcZYtzGq67bw7W48YsCtewXK8FhJuWw2yREuRDi yNv7ihYjne45OTZQuZI2Yu22sln6IvCD9R7FHZpH2aRrzHVNSqaV/BeqxTQu9/aD+88m JXIiAMHvbXFDbAcEfI2OPCbJX+LK/QusBPvf2nWCKrwa1saWv8AdLMy9V8Em6rHIGlxU 066YsC2O3qpQOaJaCyKp3od94oh4vqe6dKN+KGXAb67cLbxZN6F/CcBHnszInM28xP9V kw+g== X-Received: by 10.180.210.231 with SMTP id mx7mr55508893wic.31.1426163076710; Thu, 12 Mar 2015 05:24:36 -0700 (PDT) Received: from laptop1 (84.95.210.61.forward.012.net.il. [84.95.210.61]) by mx.google.com with ESMTPSA id ub1sm9775125wjc.43.2015.03.12.05.24.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Mar 2015 05:24:36 -0700 (PDT) From: "Raz Amir" To: "'Bruce Richardson'" References: <1424932400-66862-1-git-send-email-razamir22@gmail.com> <1425572663-22299-1-git-send-email-razamir22@gmail.com> <20150311102621.GA12704@bricha3-MOBL3> In-Reply-To: <20150311102621.GA12704@bricha3-MOBL3> Date: Thu, 12 Mar 2015 14:24:31 +0200 Message-ID: <0a0a01d05cbf$7f563750$7e02a5f0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQL76vl+o9soqPI/+Wx+6keMGfRa0gGdV5NWAxxtXjyam9d40A== Content-Language: en-gb Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] pci: save list of detached devices, and re-probe during driver unload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 12:24:37 -0000 Thank you. Can you tell when will the patch be pushed to the source code? -----Original Message----- From: Bruce Richardson [mailto:bruce.richardson@intel.com] Sent: 11 March 2015 12:26 To: Raz Amir Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] pci: save list of detached devices, and re-probe during driver unload On Thu, Mar 05, 2015 at 06:24:23PM +0200, Raz Amir wrote: > Added code that saves the pointers to the detached devices, during > driver loading, and during driver unloading, go over the list, and > re-attach them by calling device_probe_and_attach on each device. > > Signed-off-by: Raz Amir Acked-by: Bruce Richardson > --- > lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 34 > ++++++++++++++++++++++++++++----- > 1 file changed, 29 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > index 5ae8560..7a4ed5d 100644 > --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c > @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); > > #define MAX_BARS (PCIR_MAX_BAR_0 + 1) > > +#define MAX_DETACHED_DEVICES 128 > +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; static > +int num_detached = 0; > > struct nic_uio_softc { > device_t dev_t; > @@ -288,17 +291,38 @@ nic_uio_load(void) > function = strtol(token, NULL, 10); > > dev = pci_find_bsf(bus, device, function); > - if (dev != NULL) > - for (i = 0; i < NUM_DEVICES; i++) > - if (pci_get_vendor(dev) == devices[i].vend && > - pci_get_device(dev) == devices[i].dev) > - device_detach(dev); > + if (dev == NULL) > + continue; > + > + for (i = 0; i < NUM_DEVICES; i++) > + if (pci_get_vendor(dev) == devices[i].vend && > + pci_get_device(dev) == devices[i].dev) { > + if (num_detached < MAX_DETACHED_DEVICES) { > + printf("nic_uio_load: detaching and storing dev=%p\n", dev); > + detached_devices[num_detached++] = dev; > + } > + else > + printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. dev=%p won't be reattached\n", > + MAX_DETACHED_DEVICES, dev); > + device_detach(dev); > + } > } > } > > static void > nic_uio_unload(void) > { > + int i; > + printf("nic_uio_unload: entered ... \n"); > + > + for (i = 0; i < num_detached; i++) { > + printf("nic_uio_unload: calling to device_probe_and_attach for dev=%p...\n", > + detached_devices[i]); > + device_probe_and_attach(detached_devices[i]); > + printf("nic_uio_unload: done.\n"); > + } > + > + printf("nic_uio_unload: leaving ... \n"); > } > > static int > -- > 2.1.2 >