Re: [dpdk-dev] [PATCH 1/7] net/sfc/base: add a new means to control RSS hash

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 04/06/2018 08:21 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> Currently, libefx has no support for additional RSS modes
> available with later controllers. In order to support this,
> libefx should be able to list available hash configurations.
>
> This patch provides basic infrastructure for the new interface.
> The client drivers will be able to query the list of supported
> hash configurations for a particular hash algorithm. Also, it
> will be possible to configure hashing by means of new definitions.
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>   drivers/net/sfc/base/ef10_rx.c |  29 ++++++++--
>   drivers/net/sfc/base/efx.h     |  90 +++++++++++++++++++++++++++++
>   drivers/net/sfc/base/efx_rx.c  | 126 +++++++++++++++++++++++++++++++++++++++--
>   3 files changed, 236 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c
> index 86a6ac7..e7dd1ea 100644
> --- a/drivers/net/sfc/base/ef10_rx.c
> +++ b/drivers/net/sfc/base/ef10_rx.c
> @@ -298,11 +298,32 @@ efx_mcdi_rss_context_set_flags(
>   	__in		uint32_t rss_context,
>   	__in		efx_rx_hash_type_t type)
>   {
> +	efx_rx_hash_type_t type_ipv4 = EFX_RX_HASH(IPV4, 2TUPLE);

Self NACK, will send v2
It breaks clang build because of false positive warning


[...]