From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CE8145BAC; Wed, 23 Oct 2024 08:27:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49E8540DD3; Wed, 23 Oct 2024 08:27:45 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 33E3540DCD for ; Wed, 23 Oct 2024 08:27:42 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XYJw13w5czyTf2; Wed, 23 Oct 2024 14:26:09 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id D33A11800D9; Wed, 23 Oct 2024 14:27:40 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 23 Oct 2024 14:27:40 +0800 Message-ID: <0a102761-acf2-f00a-7311-04e2c75ea2fe@huawei.com> Date: Wed, 23 Oct 2024 14:27:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v11 2/2] examples/l3fwd-power: add PM QoS configuration To: Konstantin Ananyev , "dev@dpdk.org" CC: "mb@smartsharesystems.com" , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "anatoly.burakov@intel.com" , "david.hunt@intel.com" , "sivaprasad.tummala@amd.com" , "stephen@networkplumber.org" , "david.marchand@redhat.com" , Fengchengwen , liuyonglong References: <20240320105529.5626-1-lihuisong@huawei.com> <20241021114253.31216-1-lihuisong@huawei.com> <20241021114253.31216-3-lihuisong@huawei.com> <2ddabc6f1f4b45289aa63b46ec0867ec@huawei.com> From: "lihuisong (C)" In-Reply-To: <2ddabc6f1f4b45289aa63b46ec0867ec@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Konstantin, 在 2024/10/22 17:10, Konstantin Ananyev 写道: > >> Add PM QoS configuration to declease the delay after sleep in case of >> entering deeper idle state. > I still think it is worth to mention this behavior change somewhere in the docs. > Probably release_notes or sample app guides. I see some descriptions that application may enter deeper C-state in the "Overview" chapter of l3_forward_power_man.rst. So I feel it's better to add a new command parameter for it as you suggested. Please have a look again, thanks.😁 >> Signed-off-by: Huisong Li >> Acked-by: Morten Brørup >> --- >> examples/l3fwd-power/main.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c >> index 2bb6b092c3..b0ddb54ee2 100644 >> --- a/examples/l3fwd-power/main.c >> +++ b/examples/l3fwd-power/main.c >> @@ -47,6 +47,7 @@ >> #include >> #include >> #include >> +#include <...> >> } >> >> -- >> 2.22.0