From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BE0057CE5 for ; Wed, 20 Sep 2017 18:55:52 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2017 09:55:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,421,1500966000"; d="scan'208";a="902273305" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2017 09:55:49 -0700 To: "David Harton (dharton)" , "thomas@monjalon.net" Cc: "dev@dpdk.org" References: <20170810132952.26974-1-dharton@cisco.com> <20170901022631.19529-1-dharton@cisco.com> From: Ferruh Yigit Message-ID: <0a1cfa31-1eda-41f3-db8f-5585056e6774@intel.com> Date: Wed, 20 Sep 2017 17:55:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add return code to rte_eth_stats_reset() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 16:55:53 -0000 On 9/20/2017 3:01 PM, David Harton (dharton) wrote: > > >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> >> On 9/1/2017 3:26 AM, David Harton wrote: >>> Some devices do not support reset of eth stats. An application may >>> need to know not to clear shadow stats if the device cannot. >>> >>> rte_eth_stats_reset is updated to provide a return code to share >>> whether the device supports reset or not. >>> >>> Signed-off-by: David Harton >>> --- >>> >>> v5: >>> * squashed doc patch >>> * moved rel_note change from ABI to API section >>> >>> v4: >>> * commented return values >>> >>> v3: >>> * overcame noob errors and figured out patch challenged >>> >>> v2: >>> * fixed soft tab issue inserted while moving changes >>> >>> doc/guides/rel_notes/release_17_11.rst | 13 +++++++++++++ >>> lib/librte_ether/rte_ethdev.c | 8 +++++--- >>> lib/librte_ether/rte_ethdev.h | 6 +++++- >>> 3 files changed, 23 insertions(+), 4 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/release_17_11.rst >>> b/doc/guides/rel_notes/release_17_11.rst >>> index 22df4fd..6282667 100644 >>> --- a/doc/guides/rel_notes/release_17_11.rst >>> +++ b/doc/guides/rel_notes/release_17_11.rst >>> @@ -110,6 +110,19 @@ API Changes >>> Also, make sure to start the actual text at the margin. >>> ========================================================= >>> >>> +* **Modified the return type of rte_eth_stats_reset.** >>> + >>> + Changed return type of ``rte_eth_stats_reset`` from ``void`` to >>> + ``int`` so the caller may know whether a device supports the >>> + operation or not and if the operation was carried out. >>> + >> >>> +* **Modified the vlan_offload_set_t function prototype in the ethdev >>> +library.** >>> + >>> + Changed the function prototype of ``vlan_offload_set_t``. The >>> + return value has been changed from ``void`` to ``int`` so the >>> + caller to knows whether the backing device supports the operation >>> + or if the operation was successfully performed. >>> + >> >> Is this addition to the document related to this patch? > > Good catch. No. :( > > I must have mishandled the rebase I did to update this patch. V6 coming. > Would be great if you could re-ACK afterwards so this one can move. I think you can carry the previous Ack for this case. Since main part of the patch that acked will not be changed... > > Thanks, > Dave <...>