From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id A13CF28FD for ; Fri, 27 Jan 2017 20:04:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1121; q=dns/txt; s=iport; t=1485543899; x=1486753499; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1pVIilKbgs9HzzaUrv9kkCgOA2FNS5mF6bFWotT6B3A=; b=Too90NAqEOglb+tkMr6lq01NrDs/8jlxASsgKzpapdomZQzkByMKWUko tdQct8aWGgTIUZwCzJqNKLGam8nLNDlVI3MRcwPNZ6BxZwLMmwxiz2xvc cVdUymauHfD7FU2RnD9svU1Z/YFWFspVbHy74iYtuDH44O0rxeioL/zxb 4=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ASAQC9mItY/4gNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1OBageNV5ICkyGCD4IMhiICgiQ/GAECAQEBAQEBAWIohGkBAQE?= =?us-ascii?q?EOj8MBAIBCBEEAQEBHgkHMhQJCAIEDgUIiVmve4pyAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBHYZLhG+KLgWbUQGRb4IChRKJaZJ9AR84gUsVhnR1h2iBDQEBAQ?= X-IronPort-AV: E=Sophos;i="5.33,296,1477958400"; d="scan'208";a="378163510" Received: from alln-core-3.cisco.com ([173.36.13.136]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Jan 2017 19:04:58 +0000 Received: from XCH-ALN-007.cisco.com (xch-aln-007.cisco.com [173.36.7.17]) by alln-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id v0RJ4wa6015376 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 27 Jan 2017 19:04:58 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-ALN-007.cisco.com (173.36.7.17) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 27 Jan 2017 13:04:57 -0600 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1210.000; Fri, 27 Jan 2017 13:04:57 -0600 From: "John Daley (johndale)" To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/enic: fix MAC address add and remove Thread-Index: AQHSeBB+hlT6yR7uF0m967vAddrNEaFMj14AgAAgkfA= Date: Fri, 27 Jan 2017 19:04:57 +0000 Message-ID: <0a23266508ef4e008cc575b320b19f07@XCH-RCD-007.cisco.com> References: <20170126201212.31796-1-johndale@cisco.com> <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com> In-Reply-To: <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.19.145.149] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/enic: fix MAC address add and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 19:05:00 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, January 27, 2017 3:07 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/enic: fix MAC address add and remove >=20 > On 1/26/2017 8:12 PM, John Daley wrote: > > The mac_addr_add callback function was simply replacing the primary > > MAC address instead of adding new ones and the mac_addr_remove > > callback would only remove the primary MAC form the adapter. Fix the > > functions to add or remove new address. Allow up to 64 MAC addresses > per port. > > > > Fixes: fefed3d1e62c ("enic: new driver") > > > > Signed-off-by: John Daley > > Reviewed-by: Nelson Escobar >=20 > Applied to dpdk-next-net/master, thanks. >=20 > (Since it is controversial that if this patch is a fix or implementing a = missing > feature (allow up to 64 MAC), I am getting patch as it is, but not CC'ed = to > stable tree, please shout if you disagree.) That's fine to not put it on stable. Thank you for applying. -john