From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D386FA00BE; Thu, 10 Feb 2022 16:01:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CFEF426EE; Thu, 10 Feb 2022 16:01:04 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 219344013F for ; Thu, 10 Feb 2022 16:01:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644505263; x=1676041263; h=message-id:date:to:cc:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=ci13wKwj7jmxXa1Y8SOtjaInsZOLUoAeDmE/zxSFjjY=; b=bym5pqgcCYA3VvDhmQaXLL3YGBfL378JQns4wSRKQX1G1F23fYh8/9CU Cxj3+LeECwd4JyaXUY2GHn0hHLekljYBfNGJHIhgDVXrifkbRLl/Lnhlx zAM31ygQUsHunMK1nKNs5RtgF8EB1K8T3Yn3xAtgonK5fA7P0HN/Po9LP kyTAMcnwVAYaornaAGwLW6Z6bYcgTkxTRxvhJ5MB7iLrMxJLd7vaJnIYc jfMOFlY8tTJmHfaq+mkqnIHLpMD8zL7AMQ+p5wzxNKkOq11obWqQ02QKB 2gnWiP5aOJYvlKw6uXHAiSnelNjh+A2wmDziVFqCMTLy6q2FwqHQ6LZQx A==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="248337803" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="248337803" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 07:01:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="622702619" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2022 07:00:59 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 07:00:59 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 07:00:59 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 07:00:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LfWrX3sLGNtW0GLmzASdJFpvq7e76qZuV0wAsFNC5Tuy5AghDNAnM3ljLVQp61OVNRS2Sa4kZGjwrqwBf5kPFz8Q4SszbuJM64ji/k03toZyzVORvRgesyrNmnau+LvwgSp60PbiEJidWGzMPcG/J247JTfEjr6me6Y1aKJDxBvZz2J7itpk0vB2o4yCk0w8kCTq2bmi+0LOnnhdzR+Fo4z/EeyDp50I6XRKXQovsC5jhgWYg0ChjcMJ3bcijCEq2bF9GK6n9h2ioZR1KTsrgdnkLxTjNweQ99ioTcXLeSkt0mKMikaE5CJYr+6LD64e/u0hXICVrZN04JBvrah3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zRN6ED0mUZlc2drxHNSCExeYkpF8HKyvaUtmD0jCku0=; b=PqsQCMhOHjmBdp8ljJb7jvhuXt0l70DbGwd1WWgfVRd2Kl9rAh+cdAykufroe3sbm+R2ia5zoi8diL8UtGa718iJjDcPzleO420NT0UIPn9VjNWElVnHKbxhp0+mzf1P+JXiOcEGBtDNs3iJppb7ZSGPr+RUXpp0xiuM14tcFb4GdfK62C6tMmbrvV3jQS8sy2oJnrUqbf1tH1gRPoCjN0Pjo9PJhYDFaN11PIM8VaArhP+uzW7+n3hXpGjlW8e5s5807xEiEOq8u8WanhwhFZV3lCvbigqN14OGjWbYli6i05w7CXOUtuJfe6UVKgIvbGVNX98PVb8CLAY3qTcamg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB4413.namprd11.prod.outlook.com (2603:10b6:208:191::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb 2022 15:00:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 15:00:57 +0000 Message-ID: <0a3f6aa6-2499-ce40-6dd0-721f70017003@intel.com> Date: Thu, 10 Feb 2022 15:00:52 +0000 Content-Language: en-US To: , CC: References: <20220210071052.527-1-madhuker.mythri@oracle.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220210071052.527-1-madhuker.mythri@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0044.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c70a4618-f39b-45ab-bdd9-08d9eca624d5 X-MS-TrafficTypeDiagnostic: MN2PR11MB4413:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aa/7efRZh68PzfqI0yoyGVwTedWpE5phc9opeig4uX1ADbCPGAjLPswfWUiQdBAW8bg/c8mcd4Ps34A9VPYRIpoXXjdBzfGBR9L3KD8pHVRtbRraFowh6aNUvu+Zu9gp8YkZBuKmezHy4z6yCTODcnxeuUzJiUZ2X1zSzjpTVxBjk/VT3eJlrj2lkbYi1Ll1rZnLOhCcAbdjpPRBkvcCj4OO/07YyHX3QKHhCUSIfKuCpM3AEaPm3+anf1l0cgKk57ukpAvcZbh/WsoUQqLNyWDWILG7zEtDxxYxytVXV9Kz5acQxACjZQ0ZeH71VV2M8VFPGuJdZx8+Z6neLsLlgaasN+h4zY/Q5K8x2bzKcp1Ev4ARsMQ1eWXeY+L1dSCFUnk8WvGShgRttJWTjtsAhCJ6MHSw8TziA/g3Pzqc+WSchjcicL/bL8B9c00o9PJglWwcbe64BujAgG/TU4qQngCmw5VLxvf9ZlmAk4z6Bev6stQRzvwvxOqAdCD6zgYGiXIz/l5dyGIKo3z6nMmzLDHT4u/F0eWXYrOTc8XKKsiaK85OQ5CoDN7FEHPXRTTSA/YWTmT883dgTIEF+xZIPMEUPlNXIi0ZFeG9BWFs1nGWCPhS/nPLooTo6741/YDe7IYPm4cp8JvffuYjhYmq4INCnEqv3LTZFJHT+jGGrvxQqM+DktU/Rttj7X47B58lEi9wFQeI4joFrhv1oDxgCZAN2QOGSYTBiU0t8QFlK3k= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(44832011)(5660300002)(31686004)(36756003)(2906002)(66556008)(66476007)(66946007)(4326008)(2616005)(26005)(186003)(83380400001)(316002)(8936002)(38100700002)(508600001)(6506007)(6512007)(6666004)(31696002)(82960400001)(53546011)(55236004)(6486002)(25626001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3FBRlJqVVlORFl4YTNlNjd4U29aMVplNXFpaWR4Z1huTU9oU3hMSXBuM2R6?= =?utf-8?B?cjY1MWk1dGo1MTFZS1RlSXdxNERzSm9FcS8xdmQ4MHZEeGwvL29Kb2xhVkpu?= =?utf-8?B?cko3aWlCdEhQWmxkelFXWmxKejkybzZzcGhRVkdKVGJGb2F3c25zYkYvWkVO?= =?utf-8?B?Uy8wa3o5eERqZWY0ZktvUUNrenpPMjdHcnp6V2lyYnphWkVQeDZOcGlqclda?= =?utf-8?B?Rk9iTEVDNEFCWGVac094aFpSOGVlWk5zcEJmcFA0WXZEWC9aaVFQdlA4Y3ox?= =?utf-8?B?OUpFWWNYZlM5K3ovMHlZbnZCYVpLWEZaQWZxVXFWMlFvdXFPVXVHdWhrcDl3?= =?utf-8?B?bjdaS0RrY0VMRy9GNnlvMXBsaHdKa2VnazkvV2l5d1lIUjc2Tms0Z2hjMGVX?= =?utf-8?B?U0dTbW01VU1Vc2RtQWZUNE91WGVEdkZnUW1NTGRaZ05WVmNNRlY2WDJPWDYv?= =?utf-8?B?NGZHZlVoWXh0MVpMVldHMmd4aXdYYUNxTFUyWXdmU2dnc1VNK1pQZGtLOUlV?= =?utf-8?B?Z2Q5K28rbEtHNklwMGg4MHAxZk5zaEM1eXlSbG4rVmI4dndFWlVDQWllTjIr?= =?utf-8?B?elF3V1F3MXVZV3VvMkdFODlKck11YWRNR0tDMVBzZnhqOGRNTHFBMjZPajRC?= =?utf-8?B?c3hyVmptRHhjZTZKODloYkQvc3RieUFlb25PRWJWdmJMeFhMSVhnb28vclpU?= =?utf-8?B?dnphVE0rNkx5cEZ5REhmakpRMnJnNW9vVUUrb1NncDJYenVaOW1NYjNrM0x4?= =?utf-8?B?aFZmMkw2a084ZWxkTUNhbDY5S2g3dWZ4OXFheHhCWHp4U08zcHZlNEF4dlN2?= =?utf-8?B?VkhDdGNPNFUvamp5OVNGNmNxSjVDWnBHTnFGZldPNG9yTk94VUdycUdmRHpM?= =?utf-8?B?Rk5hMTFSYVZVRjl1cHI3cWZTQnJqbEY1UnRnMTRDaGU0Y004RUFyZlFlREw5?= =?utf-8?B?S1RWQlIyaERaa2pFYy8rNytXMll1aDRBeFdiYkJTQXlMNzJ3V01EYU0zL0FF?= =?utf-8?B?NnNtSWlSckNMd3dJNlQyQ3ExRnJUd2Y3RHlvZmlla05YVVp6OG9UYXRGa05V?= =?utf-8?B?UzgwaFNpRncxMFZxYnJ6c3ppeUdhNkN3ZkEwWGNTWHpBN09qY2E1OFNmOEtC?= =?utf-8?B?TU9seXQ3QXBCSXBwZk50b2ZLSjJsM0ZqWDRERVFsb0phVms5VnMyNEpOblds?= =?utf-8?B?NHNhb0lxSFRrVWFMVko1MlRhamhtZ3FNUzArQVpJbjV3WW5TQWJYR3Y4aWVj?= =?utf-8?B?OHd1NVpBcURqei9OZUgrd2Q1b0Ztc2tyeFhKc2hBRzcwZzlRMmNicW9IWkxp?= =?utf-8?B?cnA0bitDOGhnbDVmTmpTZHlUemhoNjh5QjlGcVY5elBnOGIycmxyeXhPQ1gr?= =?utf-8?B?Y1lBRy9pRGdRRDQ1N2FIUVVPMFFuWFNSRktDai9tYnVNWmNxTTB4T2dYQ281?= =?utf-8?B?cHdXOUQwcG1DRzByeE1ORlo2NERPcTNTcDJsalQra05mSmZTQUphTzRIOGFp?= =?utf-8?B?YkZRak1ueEtnR3BpblFJUmdqejFNM09DdTRNMC9ENUx2VVJvckdkbEZNZ2th?= =?utf-8?B?SkxLY3ArOVNuNjVqeEd4VjUzRWxLVU5paWJUTmJuUDZTeXl2QjlUc1A1TGhV?= =?utf-8?B?NE55QXFjM015RDc3NDF2TzZpeU1ZU3VRbFIrMGVjcWZhN09jYWRWMnZlSytT?= =?utf-8?B?dURMRFFEQVdHWGZtcDRaM01yWXZxVjJmYUYreVoyLzZnM2ZxaHZKUFJwblZD?= =?utf-8?B?eEdNUmtxVHhhN0ZCcUJ2dExEMjU3dDRCQkp3U3NJZEEzMk1LU0JUekRBNDJv?= =?utf-8?B?WG1HZUxHbHM1N0tBb1BVT1VKRjJ2YVppZ0VxZVNJY1BZSTQxVWVDc1J0UUhD?= =?utf-8?B?SDdVa1BBVzRNODhXOVRJTHlzYlpheldNaEs3QnZZaTk3WldmZFRtcDVKMG96?= =?utf-8?B?bnVtUmxwanMrYmROdWc4QWpsQ2lxZ1luQVF4dHRzNUpVbG9QcWwyYVUwRW1J?= =?utf-8?B?NnhxaVRGOCtTc3hrazMwMDJlaFlpODY2TVNxTTE3bW91RlpQRDJKK3FyOW5w?= =?utf-8?B?MVVjT3dCMEZFMC9vZGlmZURDeFFGc0tFWmF2NHZhelBEL1ROR3AxTFg4QUJD?= =?utf-8?B?WTBDWFZOYkVEZ1pJN09hQi9GMnQyb1lCdm1Jc0tnTWtmMXdJS3l4WERmSCtw?= =?utf-8?Q?/hv0k3rcLHpS0B493tCv/QE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c70a4618-f39b-45ab-bdd9-08d9eca624d5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 15:00:57.8692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VY2kMeHF8zKOTTPv7tu1sfTJT13ALs+y6ulH2y/jX2GLQ3yOYs5whCdQ91x7sg5vN9UeDIbb8u8FoiSAid4TEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4413 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2022 7:10 AM, madhuker.mythri@oracle.com wrote: > From: Madhuker Mythri > > Failsafe pmd started crashing with global devargs syntax as devargs is > not memset to zero. Access it to in rte_devargs_parse resulted in a > crash when called from secondary process. > > Bugzilla Id: 933 > > Signed-off-by: Madhuker Mythri > --- > drivers/net/failsafe/failsafe.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c > index 3c754a5f66..aa93cc6000 100644 > --- a/drivers/net/failsafe/failsafe.c > +++ b/drivers/net/failsafe/failsafe.c > @@ -360,6 +360,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) > if (sdev->devargs.name[0] == '\0') > continue; > > + memset(&devargs, 0, sizeof(devargs)); > /* rebuild devargs to be able to get the bus name. */ > ret = rte_devargs_parse(&devargs, > sdev->devargs.name); if 'rte_devargs_parse()' requires 'devargs' parameter to be memset, what do you think memset it in the API? This prevents forgotten cases like this.